[$250] Android - Chat - Both parentheses and code block alignment is not same

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression t sting, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app in both Android and mweb
2. Open a chat
3. Paste the text - def test_code(): print(ode block test)
4. Send the message
5. Note code block and Parentheses alignment

Expected Result:

Both parentheses and code block alignment must be same

Actual Result:

In Android, slightly above parentheses, code block is displayed. In mweb, both parentheses and code block display in same line

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844887140240525614
• Upwork Job ID: 1844887140240525614
• Last Price Increase: 2024-11-01

Issue Owner

Current Issue Owner: @hungvu193

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #Live Markdown

[kushu7]

Proposal

Please re-state the problem that we are trying to solve in this issue.

parentheses and code block alignment is not same mismatch

What is the root cause of that problem?

Its happening because we are providing height here.

App/src/components/InlineCodeBlock/WrappedText.tsx

Line 62 in 1d0fa64

style={styles.codeWordWrapper}

What changes do you think we should make in order to solve the problem?

By removing height element from here fixes the issue.
This file is used for Android and IOS only.

App/src/components/InlineCodeBlock/WrappedText.tsx

Line 62 in 1d0fa64

style={styles.codeWordWrapper}

Checked on both android and ios.

Android

Ios

What alternative solutions did you explore? (Optional)

None

[alexpensify]

Adding this one to my test list and will get to it later this week.

[alexpensify]

No update yet

[melvin-bot]

@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021844887140240525614

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[alexpensify]

@hungvu193 - when you get a chance, can you see if this proposal will fix this issue? Thanks! I'm able to replicate on my Android device. Thanks!

[hungvu193]

@hungvu193 - when you get a chance, can you see if this proposal will fix this issue? Thanks! I'm able to replicate on my Android device. Thanks!

Oops let's reopen it 😂

[hungvu193]

I can reproduce this one, reviewing shortly

[hungvu193]

Hi @kushu7, your proposal worked. However please elaborate a bit more about your RCA.
The height of codeWordWrapper style was added a long time ago and it was increased to 20 to fix this issue.
My question here is what are the recent changes that introduced this bug?

[kushu7]

Hi @kushu7, your proposal worked. However please elaborate a bit more about your RCA. The height of codeWordWrapper style was added a long time ago and it was increased to 20 to fix this issue. My question here is what are the recent changes that introduced this bug?

I looked into the issue at #4005 (comment). The problem arose when we switched from using RN Text to Expensify Text while on a beta version of RNRH. Although the library was later fixed, I tested a two-month-old version of our app to identify which PR caused the issue but couldn’t pinpoint it; the issue was still present in the older version. This suggests it might stem from internal library changes. The issue can be seen properly if we use parentheses. Otherwise codeblock base is matched with other alphabet base

See

[hungvu193]

while on a beta version of RNRH

I'm sorry but what does this mean?

[kushu7]

while on a beta version of RNRH

I'm sorry but what does this mean?

react-native-render-html

[melvin-bot]

@alexpensify @hungvu193 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[hungvu193]

I don't think we can go forward without a clear RCA. Still looking for proposals with a clear RCA!

[bernhardoj]

This is actually an old issue.

[hungvu193]

hmm linked facebook PR was closed :/

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@alexpensify, @hungvu193 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hungvu193]

Not overdue.

[alexpensify]

@bernhardoj are you suggesting that we should close this issue?

[bernhardoj]

@alexpensify nope, I just want to link to the RCA of the issue 😅

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@alexpensify, @hungvu193 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alexpensify]

Not overdue, waiting for proposals here

[melvin-bot]

@alexpensify @hungvu193 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[hungvu193]

Not overdue

[hungvu193]

Same

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[hungvu193]

According to #8132 (comment), it looks like we don't have plan to fix this bug yet. We can close this one @alexpensify

[alexpensify]

Thanks, closing in favor of #8132 (comment).