[BE - Requires Internal Engineer] [$250] Web - Hold - Red dot is lost on held expense when approve pending amount

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.48-2
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #49910
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Log in with your Approver account
2. As employee Go to the room with the two expenses
3. As employee: hold one expense
4. Verify there is a red dot on held expense on both sides
5. As Approver: Approve just the pending amount
6. As Approver: back to room by click to the header

Expected Result:

Red dot should remain on held report when Approver go back to room

Actual Result:

Red dot disappears from held expense when approve pending amount. It appears only when open the held report again and navigate back to room

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6634951_1728975645603.Recording__4253.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846971961812039151
• Upwork Job ID: 1846971961812039151
• Last Price Increase: 2024-11-28

Issue Owner

Current Issue Owner: @ntdiary

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[zanyrenney]

moving to expense.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021846971961812039151

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[Windchasers]

Quick question, how do we make a account approver and another employee? Thanks for any help.

[FitseTLT]

BE bug the report on hold is not returned by the BE after paying.

[melvin-bot]

@ntdiary, @zanyrenney Eep! 4 days overdue now. Issues have feelings too...

[ntdiary]

App/src/components/ReportActionItem/ReportPreview.tsx

Lines 156 to 162 in 4f0ca94

	const hasErrors =
	(hasMissingSmartscanFields && !iouSettled) ||
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	ReportUtils.hasViolations(iouReportID, transactionViolations) ||
	ReportUtils.hasWarningTypeViolations(iouReportID, transactionViolations) ||
	(ReportUtils.isReportOwner(iouReport) && ReportUtils.hasReportViolations(iouReportID)) ||
	ReportUtils.hasActionsWithErrors(iouReportID);

When Approver goes back to room, the hold violation data doesn't exist yet, so ReportPreview will not display RBR, that data will return by server if approver opening the held report.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@ntdiary, @zanyrenney Eep! 4 days overdue now. Issues have feelings too...

[ntdiary]

This issue requires an internal engineer. When an employee puts an expense on hold, our app doesn't push the hold violation data to the approver, so their ReportPreview component won't display RBR.
Unless ReportPreview also checks the hold field in the transaction_xxx like the MoneyRequestPreview does to display RBR.
cc @zanyrenney

[zanyrenney]

We require an internal engineer here. I have applied the lable

[melvin-bot]

@ntdiary, @zanyrenney 12 days overdue now... This issue's end is nigh!

[ntdiary]

We require an internal engineer here. I have applied the lable

Eh, @zanyrenney, it seems that an internal engineer hasn't been assigned automatically? 😂

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@ntdiary, @zanyrenney Eep! 4 days overdue now. Issues have feelings too...

[zanyrenney]

it seems that an internal engineer hasn't been assigned automatically? 😂
That's working as expected.

[zanyrenney]

Seeing as we have said expense is lower priority, I am going to move this to weekly. It is tagged correctly in expense.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[zanyrenney]

This is on Hold right now and not a priority.

[garrettmknight]

I actually think this fits in a cohort room since it definitely affects our current cohort. I've moved to #convert since we're pitching Hold to new users.

[melvin-bot]

This issue has not been updated in over 15 days. @ntdiary, @zanyrenney eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@ntdiary, @zanyrenney, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.