[HOLD for payment 2024-11-07] [HOLD for payment 2024-10-30] [GR Phase 1] Create empty components for all 6 steps and put them together creating a ‘frame’ of the whole process

[madmax330]

Design doc link: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=id.yapqct1l25wj

Issue Owner

Current Issue Owner: @bfitzexpensify

[MrMuzyk]

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: Frame for non USD bank account flow #51019

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @MrMuzyk does not require payment (Contractor)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot
• Contributor: @MrMuzyk is from an agency-contributor and not due payment

BugZero Checklist (@bfitzexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feature/20459 sub steps refactor #51231

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @MrMuzyk does not require payment (Contractor)

[garrettmknight]

@hungvu193 please complete the new feature checklist

[hungvu193]

Just remember that I reviewed 2 PRs for this issue #51019 and #51231.
Should the price for this issue be 500$? cc @garrettmknight and @madmax330

[bfitzexpensify]

Yes, total price should be $500 for 2 PRs, but with the regression, the total payout will be $250.

[hungvu193]

Yes, total price should be $500 for 2 PRs, but with the regression, the total payout will be $250.

I think that would be fair if we only apply penalty to the second PR (which one caused the regression). I'm not sure why we didn't create a separate issue for the refactor substeps 😬

[bfitzexpensify]

That's fair - so 1st PR at $250, and second PR at $125 with the regression.

@hungvu193 can you propose regression test steps to ensure the new feature will work correctly on production in further releases, and then I'll post the payment summary?

[hungvu193]

Sure thing. I'll propose regression test later today 😁

[hungvu193]

Regression Test:

Enable payments flow:

1. Log in to the App
2. Go to Settings -> Wallet
3. Add bank account
4. Click "Enable wallet"
5. Test all the "Personal info" steps full name, address, date of birth.

Reimbursement account - personal info flow:

1. Log in to the App
2. Create a new workspace
3. Invite new member to the workspace
4. Go to More features section and enable the Expensify Card option
5. Go to Expensify Card section that just appeared
6. Tap Issue new card
7. Go through the process of connecting to the bank account.
8. At some point in the process you'll need to provide requestor information like first and last name, date of birth etc. - test if it works correctly

Reimbursement account - beneficial owner info flow:

1. Repeat steps 1-7 described above
2. On the later steps of the process, you'll be asked: "Do you own 25% or more of Alberta Bobbeth Charleson?" - select "No"
3. On the next step: "Do any individuals own 25% or more of Alberta Bobbeth Charleson?" - select "Yes"
4. You'll land on the next personal info multiple steps form - test it if it works correctly.

Missing personal info for issuing the card flow:

1. Log in to the App as User A.
2. Go to the Workspace that you are admin of.
3. Invite a completely new user (User B).
4. Turn on Expensify Card for this workspace if not done yet.
5. Set it up
6. Tap "Issue new card" and issue the card for User B.
7. Log in to the App as User B.
8. Go to the Workspace chat - you should see the "Add shipping details" button - tap it.
9. You'll see the multiple-step form asking you to fill in your personal details - test it and make sure it works as expected.

[bfitzexpensify]

Thank you!

Payment summary:

@hungvu193 to be paid $375 through NewDot Manual Requests
@MrMuzyk does not require payment (Contractor)

[garrettmknight]

$375 approved for @hungvu193