Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error appears when try to issue card for a new user on private domain #51265

Closed
5 of 8 tasks
IuliiaHerets opened this issue Oct 22, 2024 · 27 comments
Closed
5 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #50489
Issue reported by: Applause Internal Team

Action Performed:

Precondition: workspace with enabled Expensify card feature. Bank account is added via Expensify card.

  1. Navigate to Workspace settings - Members
  2. Invite a member (with private domain email), that doesn't have an account yet
  3. Navigate to Workspace settings - Expensify Card
  4. Click on the "Issue new card" button
  5. Select the new member
  6. Select "Physical card
  7. Add the card with any limit type, limit and name
  8. Click Issue card

Expected Result:

Card is added.
In workspace chat with a member the message would show 'issued ${assignee} an Expensify Card! The card will be shipped once shipping details are added.'

Actual Result:

An error appears 'Oops... something went wrong and your request could not be completed. Please try again later.'

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6642115_1729606609519.ecard_fail.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 22, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link

melvin-bot bot commented Oct 22, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 22, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 22, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 2

@joekaufmanexpensify
Copy link
Contributor

Setting up a test workspace feed using the Plaid test account so I can test this.

@joekaufmanexpensify
Copy link
Contributor

I could not reproduce this bug at all. Not sure if you see any issue @AndrewGable ?

2024-10-22_14-25-01.mp4

@AndrewGable
Copy link
Contributor

Cannot reproduce either.

Google.Chrome.2024-10-22.at.15.20.40.mp4

@joekaufmanexpensify
Copy link
Contributor

@IuliiaHerets are you still able to reproduce this?

@joekaufmanexpensify joekaufmanexpensify added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 22, 2024
@joekaufmanexpensify
Copy link
Contributor

Demoting to daily while we figure this one out.

@mountiny mountiny assigned mountiny and unassigned AndrewGable Oct 23, 2024
@mountiny
Copy link
Contributor

Taking over, it is expected that the account has to be validated if we want to issue them a card.

I am working with @koko57 to handle this flow better from uz perspective and give the admin better error message

@joekaufmanexpensify
Copy link
Contributor

Great. TY!

@joekaufmanexpensify
Copy link
Contributor

Still in progress

@joekaufmanexpensify
Copy link
Contributor

@mountiny Is there an ETA for you or @koko57 raising a PR here?

@mountiny
Copy link
Contributor

I have started a pr when travelling on the weekend here, I need to test it and clean it up before it go for a review, hopefully I can do that by tomorrow https://github.com/Expensify/Web-Expensify/pull/44156

@joekaufmanexpensify
Copy link
Contributor

Sounds good!

@joekaufmanexpensify
Copy link
Contributor

PR still in progress

@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
@joekaufmanexpensify
Copy link
Contributor

@mountiny do you think the PR for this one will be up this week?

@melvin-bot melvin-bot bot removed the Overdue label Nov 4, 2024
@mountiny
Copy link
Contributor

mountiny commented Nov 4, 2024

I will try to prioritize it

@joekaufmanexpensify
Copy link
Contributor

TY!

Copy link

melvin-bot bot commented Nov 5, 2024

@mountiny @joekaufmanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@mountiny
Copy link
Contributor

mountiny commented Nov 6, 2024

PR is ready for a review

@mountiny mountiny added the Reviewing Has a PR in review label Nov 6, 2024
@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed Daily KSv2 labels Nov 6, 2024
@joekaufmanexpensify
Copy link
Contributor

Thanks Vit!

@mountiny
Copy link
Contributor

mountiny commented Nov 8, 2024

Still going to follow up with handling the errors for physical cards

@joekaufmanexpensify
Copy link
Contributor

Great. TY!

@mountiny
Copy link
Contributor

PR is in review

@joekaufmanexpensify
Copy link
Contributor

@mountiny I see your PR is on prod and I think this one is all set now. Closing for now, but LMK if anything else is needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants