[HOLD for payment 2022-01-11] [$1000] Copying messages with markdown via CTRL + C does not keep formatting

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Send several messages each with a different markdown (bold, strike, italic, and hyperlink)
2. Copy and paste each of the messages in compose box via the ctrl +C method

Expected Result:

HTML Markdown should be copied and pasted.

Actual Result:

HTML Markdown is not copied and user has to add the markdown again.

Workaround:

HTML Markdown is not copied and user has to add the markdown again.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.94-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @Jag96 / @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1631123012073500?thread_ts=1631122717.073400&cid=C01GTK53T8Q

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[isagoico]

Comment from thread that has more information on this bug:

• From @Jag96

Note that this is a different issue from #5125, which handles the copy via Copy from clipboard. Since this has come up a few times, I'm filing an issue here so we can have something to reference in the future.
The credit for finding this bug goes to @parasharrajat who asked about it initially in this issue.
The issue here is:

When I copy the existing sent message which is formatted and pastes it. it does not convert to formatted MD strings. The main issue here is that we don't use HTML semantic tags for rendering Every type of element is made with div and styling rules. Which we can't really interpret ATM.

So in order to fix this issue, we would have to use html tags such as a/em/b in our app instead of divs + styling.

[parasharrajat]

@isagoico You tagged the wrong guy.

[nickmurray47]

Reproduction steps are clear and confirmed this still happens locally.

So in order to fix this issue, we would have to use html tags such as a/em/b in our app instead of divs + styling.

@parasharrajat Where do these adjustments need to be made and are you interested in proposing a more detailed solution?

[parasharrajat]

I have requested the lib owner to possibly upgrade the lib so that we get this support out of the box. Otherwise, I will update here on what I think is best.

[nickmurray47]

Great, thanks @parasharrajat!

[nickmurray47]

Going to assign the External label and unassign myself, seems like a good issue for a contributor

[MelvinBot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[dylanexpensify]

Working on this now!

[dylanexpensify]

Job has been posted! 🎉

Internal: https://www.upwork.com/ab/applicants/1437772705400451072/job-details
External: https://www.upwork.com/jobs/~01ba05e404d040122d

[MelvinBot]

Triggered auto assignment to @timszot (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dylanexpensify]

not overdue

[dylanexpensify]

not overdue

[thienlnam]

PR in review here: #6732

Changes are looking good but we're working through a package-lock.json diff

[thienlnam]

Just merged the PR - now waiting on the regression period (7 days)

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.24-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Selection scraper created and integrated to project #6732
• Selection scraper created and integrated to project #6732

If no regressions arise, payment will be issued on 2022-01-11. 🎊

[mallenexpensify]

@thienlnam sanity check... before the issue, when you pasted a url into NewDot it didn't auto-hyperlink, you'd have to include markdown. Now, after this PR/issue, when you paste a link in, it's auto-hyperlinked? and.. it doesn't show the markdown it used to ?

[thienlnam]

Chatted with @mallenexpensify 1:1

It looks like the fix is not working correctly - it does hyperlinks well but for other markdown options it does not work as expected

Sent text:

When copied and pasted:

cc @kursat

[kursat]

Hey @thienlnam, @mallenexpensify,

It looks like the fix is not working correctly - it does hyperlinks well but for other markdown options it does not work as expected

Sent text:

When copied and pasted:

I am not able to reproduce issue on rev. 580c9db or on https://staging.new.expensify.com. Tried both on Firefox and Chrome on Ubuntu 20.04.3 LTS. Also checked context menus both Android and Web versions.

Can you provide details about the issue? What was the copying method? What's your environment?

[thienlnam]

We're testing this on production since the PRs have been deployed there.

Currently testing on Chrome on a Mac V11.6

Tested with copying using the context menu

and using CMD + V to paste

as well as copying using CMD + C and using CMD + V to paste

[kursat]

Its working on following env:

Chrome: Version 97.0.4692.71 (Official Build) (x86_64)
MacOS: 10.15.7 (19H1615)

2022-01-06.09-19-13.mp4

Tested with copying using the context menu

Also tried with hover menu which I noticed after shooting the video.

Currently this is what i got but I'll try to find a way to test on newer versions of mac.

[parasharrajat]

It should be platform agnostic. Maybe we are missing some step here.

[thienlnam]

Huh, I retested this morning and it is working as expected - maybe the deploy didn't install on prod until recently. Either way, all good here - thanks for confirming!

[dylanexpensify]

Payment sent for both @parasharrajat and @kursat! Contracts ended, job posting closed

[dylanexpensify]

@parasharrajat created new job for you to apply to to get paid for reporting via agency account! https://www.upwork.com/jobs/~01c306c74dd75512bf

[dylanexpensify]

offer sent

[dylanexpensify]

payment sent, job closed, contract ended fr Rajat