Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify access to the debug menu #51421

Closed
Julesssss opened this issue Oct 24, 2024 · 8 comments
Closed

Simplify access to the debug menu #51421

Julesssss opened this issue Oct 24, 2024 · 8 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Oct 24, 2024

Problem

The debug menu isn't currently accessible in HybridApp due to versioning mismatch, as our logic requires the version to be higher than the current production app version. THis isn't currently possible for HybridApp due to a number of reasons:

Perhaps we can just make it available via the four-finger-tap/cmd+d on production

Discussed here.

Action performed

  • Open the Expenisfy Hybrid app
  • Sign into a valid account and access the ND features within the app
  • Go to Account section > Troubleshoot > Scroll down
  • Debug menu is not displayed

Solution

Lets simplify access to the debug in App/HybridApp rather than solving wider repo/versioning issues.

View all open jobs on GitHub

@Julesssss Julesssss added Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Oct 24, 2024
@Julesssss Julesssss self-assigned this Oct 24, 2024
@blazejkustra
Copy link
Contributor

Commenting for assignment 👀

@blazejkustra
Copy link
Contributor

Update: I wasn't able to finish it today, as react-compiler and web/desktop fast refresh have taken all my time, sorry!

Meanwhile, do you know how to open the debug menu on mobile platforms @Julesssss? I think I've seen in some QA videos that they opened it with some keyboard shortcut on all sort of pages but I can't find it 😒

Unless I'm confusing something and debug menu is only available from troubleshooting page? cc @lanitochka17

@blazejkustra
Copy link
Contributor

Perhaps we can just make it available via the four-finger-tap/cmd+d on production

@Julesssss Should it be available only on troubleshooting page or everywhere, what's your expectation?

@Julesssss
Copy link
Contributor Author

do you know how to open the debug menu on mobile platforms @Julesssss?

Hey Błażej, I think you are referring to the 4-finger-tap menu. On mobile it should work everywhere by touching the screen with four fingers. But let me know if that isn't working for you.

@blazejkustra
Copy link
Contributor

On mobile it should work everywhere by touching the screen with four fingers.

I wasn't aware of that, thanks!

But let me know if that isn't working for you.

It works on a physical device 🙌

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Oct 28, 2024
@melvin-bot melvin-bot bot changed the title Simplify access to the debug menu [HOLD for payment 2024-11-07] Simplify access to the debug menu Oct 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

@Julesssss Julesssss changed the title [HOLD for payment 2024-11-07] Simplify access to the debug menu Simplify access to the debug menu Nov 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 8, 2024
@Julesssss
Copy link
Contributor Author

Closing this, no payment required. Deployed last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants