Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-11] [HOLD for payment 2024-11-07] Android Hybrid - Launch - App crashes everytime it is launched. #51682

Closed
1 of 8 tasks
lanitochka17 opened this issue Oct 29, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.55-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the Expensify app
  2. Verify the app is correctly opened and can be navigated properly

Expected Result:

The user should be able to launch the app, log in and navigate properly

Actual Result:

The Expensify app crashes everytime it is launched

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6649543_1730220888290.9.0.55-2.mp4

logs3.txt

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 29, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@arosiclair
Copy link
Contributor

@mountiny @hannojg @kirillzyusko looks like you guys just worked on this here: #51454. Can you guys take a look?

@arosiclair
Copy link
Contributor

I do not have access to the beta version of OldApp atm so I'm having trouble reproducing.

@kirillzyusko
Copy link
Contributor

@arosiclair in #51454 we had a different problem (the app was trying to use LocalForage which is available on web only).

The current crash happens because of this:

Caused by: undefined is not an object (evaluating 'Store.ReportHistory.bindCacheClearingEvents') at position 81:24 in app/expensify.js

@Beamanator
Copy link
Contributor

@kirillzyusko i'm going to ping you in slack to see if you have any more ideas about that crash 🙏

@Beamanator
Copy link
Contributor

Seems this should have been fixed in #51746, right?

@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Oct 31, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 31, 2024
@melvin-bot melvin-bot bot changed the title Android Hybrid - Launch - App crashes everytime it is launched. [HOLD for payment 2024-11-07] Android Hybrid - Launch - App crashes everytime it is launched. Oct 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-07. 🎊

@arosiclair arosiclair removed the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 31, 2024
@arosiclair
Copy link
Contributor

Fixed in #51746

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 4, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Nov 4, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-11-07] Android Hybrid - Launch - App crashes everytime it is launched. [HOLD for payment 2024-11-11] [HOLD for payment 2024-11-07] Android Hybrid - Launch - App crashes everytime it is launched. Nov 4, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-11. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants