Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-26] Set up environment for LHN tests #52036

Closed
OlimpiaZurek opened this issue Nov 5, 2024 · 14 comments
Closed

[HOLD for payment 2024-11-26] Set up environment for LHN tests #52036

OlimpiaZurek opened this issue Nov 5, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@OlimpiaZurek
Copy link
Contributor

OlimpiaZurek commented Nov 5, 2024

Tracking issue: #52031

Prepare the mock data and environment needed to run LHN tests, including any dependencies, e.g. Onyx, user settings etc.

Issue OwnerCurrent Issue Owner: @OlimpiaZurek
@OlimpiaZurek OlimpiaZurek added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor

mountiny commented Nov 5, 2024

@OlimpiaZurek would you also want to take this one on to set this up for the contributors?

@mountiny mountiny self-assigned this Nov 5, 2024
@OlimpiaZurek
Copy link
Contributor Author

Yes, so you can assign me to this one as well

@zanyrenney
Copy link
Contributor

is something required of me here @mountiny ?

@mountiny
Copy link
Contributor

mountiny commented Nov 8, 2024

No, we should be able to handle this one without payments

@OlimpiaZurek
Copy link
Contributor Author

Daily Update:
I checked out the existing mocks, and it looks like we can reuse some of them. I’m setting up a few initial utility functions to get the testing going, which should make things smoother.

I also noticed some LHN tests in the codebase that are broken (and currently skipped): https://github.com/Expensify/App/blob/main/tests/unit/SidebarFilterTest.ts.

After checking them out, it looks like a few are outdated and others are hard to follow. I’ll reuse the ones that are still useful, but most aren’t needed anymore. I’ll include those reusable ones in the initial test setup, along with the new utilities.

I should have everything ready by Tuesday, as I'll have Monday off due to a bank holiday in Poland.

@mountiny
Copy link
Contributor

mountiny commented Nov 8, 2024

thanks!

Copy link

melvin-bot bot commented Nov 12, 2024

@OlimpiaZurek, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Nov 12, 2024
@mountiny
Copy link
Contributor

@OlimpiaZurek working on this

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Overdue Weekly KSv2 labels Nov 13, 2024
@melvin-bot melvin-bot bot changed the title Set up environment for LHN tests [HOLD for payment 2024-11-26] Set up environment for LHN tests Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.63-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-26. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 19, 2024

@mountiny @OlimpiaZurek The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 25, 2024
@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 25, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@mountiny
Copy link
Contributor

Setting up the tests, new feature and nobody to pay, no regression test required. I am going to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants