-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-11-26] Set up environment for LHN tests #52036
Comments
Triggered auto assignment to @zanyrenney ( |
@OlimpiaZurek would you also want to take this one on to set this up for the contributors? |
Yes, so you can assign me to this one as well |
is something required of me here @mountiny ? |
No, we should be able to handle this one without payments |
Daily Update: I also noticed some LHN tests in the codebase that are broken (and currently skipped): https://github.com/Expensify/App/blob/main/tests/unit/SidebarFilterTest.ts. After checking them out, it looks like a few are outdated and others are hard to follow. I’ll reuse the ones that are still useful, but most aren’t needed anymore. I’ll include those reusable ones in the initial test setup, along with the new utilities. I should have everything ready by Tuesday, as I'll have Monday off due to a bank holiday in Poland. |
thanks! |
@OlimpiaZurek, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@OlimpiaZurek working on this |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.63-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-26. 🎊 For reference, here are some details about the assignees on this issue:
|
@mountiny @OlimpiaZurek The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
Setting up the tests, new feature and nobody to pay, no regression test required. I am going to close this |
Tracking issue: #52031
Prepare the mock data and environment needed to run LHN tests, including any dependencies, e.g. Onyx, user settings etc.
Issue Owner
Current Issue Owner: @OlimpiaZurekThe text was updated successfully, but these errors were encountered: