Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per diem - Unable to edit category when Per diem is enabled #52257

Closed
6 of 8 tasks
lanitochka17 opened this issue Nov 8, 2024 · 6 comments
Closed
6 of 8 tasks

Per diem - Unable to edit category when Per diem is enabled #52257

lanitochka17 opened this issue Nov 8, 2024 · 6 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: N, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace
  3. Go to workspace settings > More features
  4. Enable Rules and Per diem (upgrade workspace when asked)
  5. Go to Category
  6. Click on any category
  7. Edit any field

Expected Result:

User should be able to edit category when Per diem is enabled

Actual Result:

User is unable to edit category when Per diem is enabled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6658765_1731066939548.20241108_195155.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 8, 2024
Copy link

melvin-bot bot commented Nov 8, 2024

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 8, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

github-actions bot commented Nov 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17 lanitochka17 added the DeployBlocker Indicates it should block deploying the API label Nov 8, 2024
@NikkiWines
Copy link
Contributor

This (and the other per diem blockers) seem like they're likely tied to the following PR: #51232

cc: @shubham1206agra @c3024 @Gonals

@NikkiWines NikkiWines added Daily KSv2 Hourly KSv2 Improvement Item broken or needs improvement. and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 DeployBlocker Indicates it should block deploying the API labels Nov 8, 2024
@NikkiWines
Copy link
Contributor

Demoted from blocker and re-assigned accordingly per this conversation

@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@Gonals
Copy link
Contributor

Gonals commented Nov 11, 2024

We are still mid-development with this (and the category stuff hasn't been deployed/tested). Since this is behind a beta, I think we can close.

@Gonals Gonals closed this as completed Nov 11, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

4 participants