[HOLD for payment 2024-12-11] [$250] mweb - Netsuite - Offline indicator is below the text in Auto-sync page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.63-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #51949

Action Performed:

Precondition:

• Workspace is connected to NetSuite

1. Go to staging.new.expensify.com
2. Go to workspace settings
3. Go to Accounting
4. Tap Advanced
5. Tap Auto-sync
6. Go offline

Expected Result:

Offline indicator will be at the bottom of the page

Actual Result:

Offline indicator is below the text instead of bottom of the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6666449_1731683684198.Screen_Recording_20241115_231142_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857460821129435659
• Upwork Job ID: 1857460821129435659
• Last Price Increase: 2024-11-15
• Automatic offers:
• rojiphil | Contributor | 104956911

Issue Owner

Current Issue Owner: @akinwale

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline indicator is below the text in Auto-sync page

What is the root cause of that problem?

We are not adding offlineindicator styles here

App/src/pages/workspace/accounting/netsuite/advanced/NetSuiteAutoSyncPage.tsx

Lines 38 to 41 in 88713ab

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.defaultModalContainer]}
	testID={NetSuiteAutoSyncPage.displayName}

What changes do you think we should make in order to solve the problem?

We should add offlineIndicatorStyle={styles.mtAuto} here

App/src/pages/workspace/accounting/netsuite/advanced/NetSuiteAutoSyncPage.tsx

Lines 38 to 41 in 88713ab

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.defaultModalContainer]}
	testID={NetSuiteAutoSyncPage.displayName}

Optional: We can also add shouldEnableMaxHeight

What alternative solutions did you explore? (Optional)

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline indicator is below the text in Auto-sync page

What is the root cause of that problem?

The content on the NetSuiteAutoSyncPage doesn't expand to the maximum screen height, causing the offline indicator to appear directly below the content.

What changes do you think we should make in order to solve the problem?

In the NetSuiteAutoSyncPage, we should use the ConnectionLayout wrapper, similar to the SageIntacctAdvancedPage,
XeroAdvancedPage component,... This approach ensures that the content expands to the maximum screen height by using ScrollView. Additionally, it aligns with the PR guidelines.

If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.

What alternative solutions did you explore? (Optional)

[twilight2294]

I will fix this as it's coming from my PR, @grgia can you demote this though ? this seems to be a non-blocker thing. c.c. @rojiphil @yuwenmemon

[yuwenmemon]

Yeah doesn't look like a blocker to me.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021857460821129435659

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

❌ There was an error making the offer to @twilight2294 for the Contributor role. The BZ member will need to manually hire the contributor.

[Nodebrute]

@twilight2294 You are right. Offending pr #51949

[akinwale]

@yuwenmemon Since this is a regression, the C+ who reviewed the initial PR can be assigned here as well, unless they're currently unavailable.

[rojiphil]

Since this is a regression, the C+ who reviewed the initial PR can be assigned here as well, unless they're currently unavailable.

Yeah! That makes sense. @yuwenmemon Please assign me here. Thanks.

[rojiphil]

@twilight2294 When can you raise a PR for this?

[twilight2294]

Working on the fix now

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.70-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Offline indicator is below the text in Auto-sync page #52723

If no regressions arise, payment will be issued on 2024-12-11. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment automatic offer (Contributor)
• @twilight2294 requires payment (Needs manual offer from BZ)

[rojiphil]

@yuwenmemon I think we can close this as we can consider this to be part of the implementation here

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @OfstadC you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[OfstadC]

@rojiphil are you indicating payment doesn't need to be issued on this issue?

[rojiphil]

@OfstadC yeah. you can close this out