Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold - Emoji context menu doesn't close when hold RHN modal opens #52749

Closed
2 of 8 tasks
IuliiaHerets opened this issue Nov 19, 2024 · 9 comments
Closed
2 of 8 tasks

Hold - Emoji context menu doesn't close when hold RHN modal opens #52749

IuliiaHerets opened this issue Nov 19, 2024 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.64-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to a workspace chat
  2. Submit two manual request
  3. Click on the IOU component and navigate to combined expense report
  4. Right click on one of the IOU > click hold

Expected Result:

Emoji context menu should close when hold RHN modal opens

Actual Result:

Emoji context menu doesn't close when hold RHN modal opens

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6669105_1731996368826.Screen_Recording_2024-11-19_at_9.05.09_in_the_morning.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 19, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 19, 2024

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 19, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 19, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rojiphil
Copy link
Contributor

Same root cause and the fix is been worked out here

@Julesssss
Copy link
Contributor

Thanks. Fix PR is here and I have just kicked off test builds.

@Julesssss Julesssss added Reviewing Has a PR in review Daily KSv2 and removed Hourly KSv2 Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Nov 19, 2024
@Julesssss
Copy link
Contributor

Asked for a retest here

@izarutskaya
Copy link

Not reproduced
Build v9.0.64-1

Recording.2903.mp4

@mallenexpensify
Copy link
Contributor

Thanks @izarutskaya ! Closing as it's not reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants