Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - Pay button does not appear on the expense after the duplicates are sorted #53023

Closed
8 tasks done
IuliiaHerets opened this issue Nov 23, 2024 · 10 comments
Closed
8 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Add approvals feature is enabled.
  • Admin is the approver.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense and pay elsewhere.
  4. Submit another expense of the same amount and merchant.
  5. Go to Search.
  6. Click Approve on the expense.
  7. Click Approve on expense RHP.
  8. Click Approve all the amount.
  9. Close the RHP.

Expected Result:

Pay button should appear on the expense because the duplicates are sorted and Pay button also appears on the expense RHP.

Actual Result:

Pay button does not appear on the expense after the duplicates are sorted.
It only appears after the page is refreshed.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6674000_1732356224342.20241123_174735.1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @luacmartins
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Nov 23, 2024
Copy link

melvin-bot bot commented Nov 23, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 23, 2024
Copy link

melvin-bot bot commented Nov 23, 2024

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 23, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 23, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@cretadn22
Copy link
Contributor

@luacmartins

This is a BE bug. The backend doesn't update a new value for action field

@mountiny
Copy link
Contributor

this is specific flow and the pay button appears after refreshing or navigating away and back so I dont think this has to be a blocker for the deploy as the user is not blocked from taking the action they want to

@melvin-bot melvin-bot bot added the Overdue label Nov 25, 2024
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 25, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 25, 2024
@luacmartins
Copy link
Contributor

I'll work on this since my PR introduced the feature

@luacmartins luacmartins assigned luacmartins and unassigned tgolen Nov 25, 2024
@luacmartins luacmartins removed the DeployBlocker Indicates it should block deploying the API label Nov 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 29, 2024

@luacmartins, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins
Copy link
Contributor

Working on it this week

@melvin-bot melvin-bot bot removed the Overdue label Dec 3, 2024
@luacmartins
Copy link
Contributor

This seems to be fixed. Closing.

Screen.Recording.2024-12-04.at.2.22.20.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants