[HOLD for payment 2025-01-02] Debug Mode - "Create" button flash after creating a violation

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: Can't check as no Debug Mode on production
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Enable debug mode in Troubleshoot
3. Open an expense thread (create one if you don't have any)
4. Enter debug view then check on "View transaction" tab
5. Go to "violations" > Create a violation and save it

Expected Result:

"Create" button does not flash after creating a violation

Actual Result:

"Create" button flash after creating a violation

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6673733_1732322393345.Screen_Recording_2024-11-23_at_3.31.20_at_night.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[DylanDylann]

cc @pac-guerreiro

[mountiny]

This is a debug feature only so not a blocker. @DylanDylann @pac-guerreiro please follow up on this one from your PR cc @puneetlath in case you want to take over as a CME too cc @fabioh8010

[pac-guerreiro]

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

[pac-guerreiro]

@IuliiaHerets I wasn't able to reproduce this behaviour on latest main, can you test it again? 😄

Screen.Recording.2024-11-25.at.20.48.16.mp4

[DylanDylann]

I still can reproduce this bug. @pac-guerreiro Could you please try again with some consecutive create?

Screen.Recording.2024-11-26.at.09.52.37.mov

[DylanDylann]

Another bug I see on the debug feature:

App/src/pages/Debug/ReportAction/DebugReportActionCreatePage.tsx

Line 117 in 3f4e93e

Debug.setDebugData(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, {[parsedReportAction.reportActionID]: parsedReportAction});

we use the set method but we don't add the previous data. It caused when adding new report action, all previous report actions will be removed

[IuliiaHerets]

@pac-guerreiro Tester also can still reproduce the issue in the latest build

Screen.Recording.2024-11-26.at.3.26.36.at.night.mp4

[pac-guerreiro]

Another bug I see on the debug feature:

App/src/pages/Debug/ReportAction/DebugReportActionCreatePage.tsx

Line 117 in 3f4e93e

Debug.setDebugData(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, {[parsedReportAction.reportActionID]: parsedReportAction});

we use the set method but we don't add the previous data. It caused when adding new report action, all previous report actions will be removed

@DylanDylann nice catch! I think it should be addressed on a separate issue, can you create it?

[pac-guerreiro]

@IuliiaHerets @DylanDylann

I'll try it again, but it's not an easy one 😅 Could you also try creating a report action to confirm if it also happens?

[pac-guerreiro]

Today I didn't have the time to test this again. Tomorrow I'll take another look at it!

[IuliiaHerets]

@pac-guerreiro Issue is reproducible, build v9.0.67-1

Screen.Recording.2024-11-27.at.1.20.29.at.night.mp4

[pac-guerreiro]

@puneetlath @IuliiaHerets

All remaining issues addressed! Now waiting on @DylanDylann to do his magic 🪄

[pac-guerreiro]

@puneetlath @IuliiaHerets

Today I resolved all conflicts in the PR 😄

[pac-guerreiro]

@puneetlath @IuliiaHerets

Today I fixed the app crash reported by @DylanDylann!

I'll be away until January 2nd but someone should take care of my work 😄 Happy holidays! 🎉

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• replace FlatList with .map solution #53655

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

• @JKobrynski does not require payment (Contractor)
• @pac-guerreiro does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @slafortune @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @JKobrynski is from an agency-contributor and not due payment
• Contributor: @pac-guerreiro is from an agency-contributor and not due payment
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@slafortune)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[puneetlath]

@DylanDylann does this require payment or is it a regression from a previous PR?

[pac-guerreiro]

@puneetlath this issue is not a regression 😉

[DylanDylann]

@DylanDylann does this require payment

I think yes

[slafortune]

@puneetlath do you have a milestone tracking that you are paying all these GH's related to debug mode?

[puneetlath]

Yes I do. Paid here: https://www.upwork.com/nx/wm/workroom/38901941

@DylanDylann I think we're done with the debug mode stuff and I can close that Upwork job out now. Is that right?

[melvin-bot]

@slafortune, @blimpich, @JKobrynski, @pac-guerreiro, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

[DylanDylann]

All done. Let's close this issue

[puneetlath]

@DylanDylann shall I also close the Upwork job out now?

[DylanDylann]

Yess

[puneetlath]

Ok, all done. Thanks y'all!