Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - App crashes when launching app #53150

Closed
1 of 8 tasks
lanitochka17 opened this issue Nov 26, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.67-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Not reproducible on ND app.
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch hybrid app
  2. Log in
  3. Switch to ND if needed

Expected Result:

App will not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6677192_1732641576881.Screen_Recording_20241127_011856.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 26, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny removed the DeployBlocker Indicates it should block deploying the API label Nov 26, 2024
@isagoico
Copy link

This was reproducible on the Hybrid app only (editing OP).
Device used: Samsung Galaxy Z Fold 4 / Android 14

@mountiny
Copy link
Contributor

Non-fatal Exception: io.invertase.firebase.crashlytics.JavaScriptError: Cannot read property 'setButtonStyle' of null
at .setButtonStyle(address at index.android.bundle:1:5378701)
at .anonymous(address at index.android.bundle:1:5072972)
at .commitHookEffectListMount(address at index.android.bundle:1:1286047)
at .commitHookPassiveMountEffects(address at index.android.bundle:1:1291027)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291477)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291450)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291220)
at .recursivelyTraversePassiveMountEffects(address at index.android.bundle:1:1291112)
at .commitPassiveMountOnFiber(address at index.android.bundle:1:1291432)
at .flushPassiveEffects(address at index.android.bundle:1:1298965)
at .flushSyncWorkAcrossRoots_impl(address at index.android.bundle:1:1251561)
at .commitRootImpl(address at index.android.bundle:1:1298717)
at .commitRoot(address at index.android.bundle:1:1298008)
at .commitRootWhenReady(address at index.android.bundle:1:1294587)
at .performConcurrentWorkOnRoot(address at index.android.bundle:1:1294036)

8:22
https://console.firebase.google.com/u/0/project/expensify-mobile-app/crashlytics/app/andro[…]079562623599&subIssues=bea7ab04ca7407d9912fa6119e4f4524

@mountiny mountiny self-assigned this Nov 26, 2024
@mountiny
Copy link
Contributor

That is the crash, its coming from the edge to edge PR on android.

It seems like that in the hybrid app, when the app switches to NewDot, the module is not ready yet and it crashes #52392

@mountiny
Copy link
Contributor

The app does not crash anymore

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Nov 28, 2024
@melvin-bot melvin-bot bot changed the title Android - App crashes when launching app [HOLD for payment 2024-12-05] Android - App crashes when launching app Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-05. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 30, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-12-05] Android - App crashes when launching app [HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - App crashes when launching app Nov 30, 2024
Copy link

melvin-bot bot commented Nov 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-07. 🎊

@raphaelsc
Copy link

9.0.74.8 is crashing to me all the time. what's the delivery of new minor version expected to reach android app stores? what's some workaround?

Copy link

melvin-bot bot commented Dec 16, 2024

📣 @raphaelsc! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@mountiny
Copy link
Contributor

Hi @raphaelsc! The crash issue should be resolved in a new version and its being slowly rolled out to the customers now. Let us know if you will have the same issue even after updating. Thank you!

@raphaelsc
Copy link

Hi @raphaelsc! The crash issue should be resolved in a new version and its being slowly rolled out to the customers now. Let us know if you will have the same issue even after updating. Thank you!

Upgraded to 9.0.75.6, and the issue has been fixed. Thanks for your kind reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants