Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login - Onboarding modal does not appear when logging in with a new account #53284

Closed
2 of 8 tasks
IuliiaHerets opened this issue Nov 28, 2024 · 13 comments
Closed
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.68-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Log in with a new gmail account

Expected Result:

Onboarding modal appears when logging in with a new Gmail account

Actual Result:

Onboarding modal doesn't appear when logging in with a new Gmail account. User is logged in to the account directly without the onboarding proccess

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6679380_1732819473281.2024-11-28_21_40_27.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Nov 30, 2024

BE issue, OpenApp api command returning empty object for onboarding value
Screenshot 2024-11-30 at 15 45 09

Copy link

melvin-bot bot commented Dec 2, 2024

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mountiny
Copy link
Contributor

mountiny commented Dec 2, 2024

Cc @trjExpensify

@trjExpensify
Copy link
Contributor

Ah, is this the bug you saw on dev only? 🤔

@trjExpensify
Copy link
Contributor

Discussing in this thread.

@melvin-bot melvin-bot bot removed the Overdue label Dec 3, 2024
@trjExpensify trjExpensify added the Reviewing Has a PR in review label Dec 3, 2024
@trjExpensify
Copy link
Contributor

Taking this over. Vit has a PR up.

@mountiny
Copy link
Contributor

mountiny commented Dec 3, 2024

PR is merged, but we could not reproduce locally as this seems to be some production specific issue when user runs into a commit, this explains flakiness. hopefully this change will fix it

@mountiny
Copy link
Contributor

mountiny commented Dec 5, 2024

This is fixed by auth PR

@mountiny mountiny closed this as completed Dec 5, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in [#whatsnext] #convert Dec 5, 2024
@Shahidullah-Muffakir
Copy link
Contributor

@trjExpensify , @mountiny I’m still experiencing this issue.
When signing up through expensify.com, the onboarding flow modal on new.expensify.com doesn’t always show up.

Screen.20Recording.202024-12-06.20at.209.mp4

@trjExpensify
Copy link
Contributor

Interesting.... seems to be working for me.

2024-12-06_18-12-09.mp4

@Shahidullah-Muffakir
Copy link
Contributor

Hmm, I see. Thanks for confirming. It seems to work fine in staging but not in production.

When I sign up through staging.expensify.com and get redirected to staging.new.expensify.com, the onboarding flow modal appears as expected.

@trjExpensify
Copy link
Contributor

Yeah, you're not the only one. It seems like we're getting mixed results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review
Projects
Development

No branches or pull requests

6 participants