[Due for payment 2025-01-21] [$250] Android - Track expense - "It's not here" page shows up briefly when deleting a track expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.68-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5277524
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition: Login to the Hybrid App with an Expensifail account.

Steps

1. Open self DM
2. Create a new track expense
3. Open the expense report
4. Click on the Header and click delete
5. Confirm the delete

Expected Result:

"It's not here" page will not show up when deleting a track expense.

Actual Result:

"It's not here" page shows up briefly when deleting a track expense.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6679551_1732832209586.delete_track_expense.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021862432764600523584
• Upwork Job ID: 1862432764600523584
• Last Price Increase: 2024-11-29
• Automatic offers:
• shubham1206agra | Reviewer | 105156932
• ikevin127 | Contributor | 105156935

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Production

video_2024-11-29_10-42-11.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021862432764600523584

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[bernhardoj]

The not found shows because shouldShowNotFoundPage, contentShown.current, and isFocused is true.

App/src/pages/home/report/withReportOrNotFound.tsx

Lines 88 to 93 in decb695

	// If the content was shown, but it's not anymore, that means the report was deleted, and we are probably navigating out of this screen.
	// Return null for this case to avoid rendering FullScreenLoadingIndicator or NotFoundPage when animating transition.
	// eslint-disable-next-line react-compiler/react-compiler
	if (shouldShowNotFoundPage && contentShown.current && !isFocused) {
	return null;
	}

I added the isFocused in #51920 so we don't render null if the screen is still focused to fix #51388. It's been deployed a month ago, so not sure what causes this. My guess is that, previously, when we delete the expense, the screen is blurred already before the report onyx data is deleted.

The comment stated

If the content was shown, but it's not anymore, that means the report was deleted, and we are probably navigating out of this screen.

which means the condition is actually not 100% reliable because we assume the user is probably navigating out of the screen. I think what we can do is delay the delete report similar to this recent PR.

[shubham1206agra]

@mountiny Can we do that ^?

[shubham1206agra]

Sorry for the delay
I will review this today

[ikevin127]

♻️ Status update: PR is pending review once again after some code changes following first review.

♻️ Status update 12/16/2024: Working on the PR, one more test case needs to pass from one of the previous issues.

♻️ Status update 12/18/2024: PR is pending review once again after latest code changes related to one of the failing tests, more details in #53408 (comment).

[melvin-bot]

This issue has not been updated in over 15 days. @nkuoch, @youssef-lr, @RachCHopkins, @ikevin127, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[ikevin127]

♻️ Status update 01/02/2024: We're still working on the PR, awaiting response from reviewer regarding latest questions / clarifications from #53408 (comment).

[ikevin127]

♻️ Status update 01/08/2024: We decided to try a simpler solution which would only fix our issue, without requiring tests for other past issues, but in the meantime, it looks like the issue is not reproducible (at least on my side) - discussing with C+ reviewer to confirm whether this is still reproducible - otherwise we can close it as fixed.

[ikevin127]

♻️ Status update 01/09/2024: Turns out PR #52740 fixed this issue without knowing. I posted my proposal on (29th of November) and the mentioned PR merged first (4th of Dec) which fixed the issue, but in turn created another bug which wasn't caught until we looked into it while we worked on the PR for this (now fixed) issue.

To be proactive, we decided together (with @shubham1206agra) that we should fix the other bug created by the PR that fixed this issue, see detailed technical explaination here.

✅ PR is already updated and ready for review! If an update is needed for this issue's title and description, here's the info:

Title: Task delete confirmation Cancel button navigates to parent report
Offending PR: #52740
Action Performed:

1. Open any report.
2. Press [+] in composer and press Assign task.
3. Input any Title and press Next then Confirm task.
4. Open task report.
5. Tap on task report header to open report details page.
6. Press Delete.
7. When delete confirmation modal opens, press Cancel.
8. Verify that pressing Cancel will simply dismiss the delete confirmation modal instead of navigating the user back to the parent report.

Expected Result: The task's delete confirmation modal Cancel button should simply dismiss the delete confirmation modal instead of navigating the user back to the parent report.
Actual Result: The task's delete confirmation modal Cancel button dismisses the delete confirmation modal and navigates the user back to the parent report.
Platforms:

• All

Screenshots/Videos:

web_before.mov

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.84-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• FIX: Task delete confirmation Cancel button navigates to parent report #53408

If no regressions arise, payment will be issued on 2025-01-21. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment automatic offer (Contributor)
• @shubham1206agra requires payment automatic offer (Reviewer)

[melvin-bot]

@ikevin127 / @shubham1206agra @RachCHopkins @ikevin127 / @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[RachCHopkins]

@ikevin127 if you can get the checklist done, I will get this paid out asap!

[ikevin127]

@RachCHopkins Sure, thank you!

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/52740/files#r1908375310.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/463764

Regression Test Proposal

1. Open any report.
2. Press [+] in composer and press Assign task.
3. Input any Title and press Next then Confirm task.
4. Open task report.
5. Tap on task report header to open report details page.
6. Press Delete.
7. When delete confirmation modal opens, press Cancel.
8. Verify that pressing Cancel will simply dismiss the delete confirmation modal instead of navigating the user back to the parent report.

Do we agree 👍 or 👎.

[ikevin127]

cc @RachCHopkins for payments

[RachCHopkins]

Payment Summary:

• Contributor: @shubham1206agra to be paid $250 via Upwork
• Contributor+: @ikevin127 paid $250 via Upwork

Upwork job here

[RachCHopkins]

@shubham1206agra your offer expired on 1 January! I have just sent you another.

@ikevin127 you have been paid.

[shubham1206agra]

@RachCHopkins Offer accepted

[RachCHopkins]

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.