Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS/Android - Categorize it - Paragraph in success message has different alignment (left-aligned) #53318

Closed
4 of 8 tasks
IuliiaHerets opened this issue Nov 29, 2024 · 14 comments
Closed
4 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.68-4
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Device font size should be small.
  • Account has no workspace.
  1. Launch ND or hybrid app.
  2. Create a new workspace.
  3. Go to workspace settings > More features.
  4. Enable Report fields.
  5. Tap Upgrade.
  6. Note that the paragraph in the success message is center-aligned.
  7. Delete the workspace.
  8. Go to self DM.
  9. Track a manual expense.
  10. Tap Categorize it.
  11. Tap Upgrade.

Expected Result:

The paragraph in the success message should be consistent with Step 6, so it should be center-aligned.

Actual Result:

The paragraph in the success message is not consistent - it is left-aligned.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6679913_1732880954130.ScreenRecording_11-29-2024_20.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 29, 2024
Copy link

melvin-bot bot commented Nov 29, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 29, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 29, 2024

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 29, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 29, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rlinoz
Copy link
Contributor

rlinoz commented Nov 29, 2024

No need to block on this, removing the label.

@rlinoz rlinoz added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 29, 2024
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 labels Nov 29, 2024
Copy link

melvin-bot bot commented Nov 29, 2024

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 29, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added the Hourly KSv2 label Nov 29, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

@rlinoz Sorry, I though I missed to put a deploy label

@IuliiaHerets IuliiaHerets removed the DeployBlockerCash This issue or pull request should block deployment label Nov 29, 2024
@rlinoz rlinoz added Daily KSv2 and removed Hourly KSv2 labels Nov 29, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Nov 29, 2024

PR that introduced the change: https://github.com/Expensify/App/pull/52737/files

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Dec 2, 2024

@nkdengineer do you mind fixing this as a followup to the PR linked above?

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@nkdengineer
Copy link
Contributor

On it today.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 3, 2024
@muttmuure
Copy link
Contributor

I'll take a look at this tomorrow

@rlinoz
Copy link
Contributor

rlinoz commented Dec 17, 2024

I believe we can simply close this one

@rlinoz rlinoz closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants