[PAID] [$250] Android - Chat - When navigating to WS link, chat is seen on the background while loading

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Open the Expensify app.
2. Tap on "Settings"
3. Tap on "Workspaces" and select any workspace.
4. Tap on "Profile" and navigate to share code.
5. Tap on "Copy URL"
6. Navigate back to LHN and open any chat,
7. Paste the workspace share code.
8. Tap on the URL.
9. Verify you are automatically navigated to workspace profile.

Expected Result:

The user should be automatically navigated to workspace profile after tapping on the URL.

Actual Result:

Chat can be seen on the background, with a loading spinner, for a few seconds, before the user is navigated to the workspace profile after tapping on the URL on chat.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6680852_1732994632298.URL.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @strepanier03

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021863541156905286108
• Upwork Job ID: 1863541156905286108
• Last Price Increase: 2024-12-02
• Automatic offers:
• daledah | Contributor | 105155655
• dominictb | Contributor | 105399428

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

@chrispader @kirillzyusko @hannojg something to look into, i dont think this is a blocker so demoted.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat can be seen on the background, with a loading spinner, for a few seconds, before the user is navigated to the workspace profile after tapping on the URL on chat.

What is the root cause of that problem?

In:

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Line 553 in 7d15aac

presentation: Presentation.TRANSPARENT_MODAL,

we are displaying the screen as the transparent modal, so previous screen is visible.

What changes do you think we should make in order to solve the problem?

We can remove that line.

What alternative solutions did you explore? (Optional)

Can use presentation: Presentation.MODAL.

[mountiny]

@daledah thanks for the proposal, we will look into that

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021863541156905286108

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: remove transparentModal from Workspace Join User screen #53434

If no regressions arise, payment will be issued on 2024-12-16. 🎊

For reference, here are some details about the assignees on this issue:

• @daledah requires payment automatic offer (Contributor)

[melvin-bot]

@mountiny @strepanier03 @daledah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@strepanier03, @mountiny, @daledah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@dominictb can you please complete the BZ checklist?

[strepanier03]

I am now out of the office until January 3.

When the checklist is completed, please post in Slack and request help to pay the Upwork contract.

[dominictb]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/37525/files#r1896349995

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: NA

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Open Settings > Workspaces
2. Select a workspace
3. Open Profiles > Share > Copy URL
4. Go to any chat
5. Send copied URL
6. Press on URL
7. Verify that: if loading indicator is shown, it is shown on a blank background (instead of a transparent overlay)

Do we agree 👍 or 👎

[melvin-bot]

@strepanier03, @mountiny, @dominictb, @daledah Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@strepanier03, @mountiny, @dominictb, @daledah Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@strepanier03 @mountiny @dominictb @daledah this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

@strepanier03, @mountiny, @dominictb, @daledah 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@strepanier03, @mountiny, @dominictb, @daledah 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

@strepanier03, @mountiny, @dominictb, @daledah 12 days overdue. Walking. Toward. The. Light...

[strepanier03]

Payment Summary

• $250 to @daledah via Upwork (offer)
• $250 to @dominictb via Upwork (offer)

[strepanier03]

Back from OoO 👋 I've paid both offers and closed the contracts in Upwork. I created the reg test request as well. Closing this out, thanks everyone!