Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android Hybrid - Login - White screen when backgrounding app after entering magic code #53397

Closed
1 of 8 tasks
vincdargento opened this issue Dec 2, 2024 · 17 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@vincdargento
Copy link

vincdargento commented Dec 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.69-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the Expensify app.
  2. Tap on "Continue With Email"
  3. Enter valid credentials.
  4. Tap on "Next" and wait until receiving the magic code.
  5. Enter the received magic code and tap on "Log In"
  6. While the app is loading, background it.
  7. Wait a few seconds and reopen it.
  8. Verify that the login process was successful and you land on inbox.

Expected Result:

The user should be correctly logged in, despite backgrounding the app during the login process.

Actual Result:

A white screen is displayed when backgrounding the app for a few seconds while loading after entering the received Magic Code. The user has to kill the app and relaunch it to enter the account after this.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

log.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863674659316493760
  • Upwork Job ID: 1863674659316493760
  • Last Price Increase: 2024-12-02
  • Automatic offers:
    • ikevin127 | Reviewer | 105172764
Issue OwnerCurrent Issue Owner: @ikevin127
@vincdargento vincdargento added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 2, 2024

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 2, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@vincdargento
Copy link
Author

@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label Dec 2, 2024
@melvin-bot melvin-bot bot changed the title Android Hybrid - Login - White screen when backgrounding app after entering magic code [$250] Android Hybrid - Login - White screen when backgrounding app after entering magic code Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021863674659316493760

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@ikevin127
Copy link
Contributor

@stitesExpensify This is Android: HybridApp therefore should be Internal as External contributors don't have access to the HybridApp repo.

@mountiny mountiny self-assigned this Dec 2, 2024
@stitesExpensify
Copy link
Contributor

ah thanks @ikevin127 I wasn't aware that hybrid app issues were specific to that repo and couldn't be caused by the regular /app repo

@ikevin127
Copy link
Contributor

Sure, usually when Android: Standalone or Android: mWeb Chrome are not checked in the Platforms section and when the issue's title states Android Hybrid we assume this is specific to Android: HybridApp.

@mountiny
Copy link
Contributor

mountiny commented Dec 2, 2024

Assigning myself too as its most likely coming from the native-stack PR that I have pushed ahead. SWM will have a look into this tomorrow

@mateuuszzzzz
Copy link
Contributor

Hi, I'm going to investigate this issue

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 3, 2024
Copy link

melvin-bot bot commented Dec 3, 2024

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@mateuuszzzzz
Copy link
Contributor

mateuuszzzzz commented Dec 3, 2024

Update: I haven't found anything that could lead to recent changes in codebase. I'm continuing investigation

EDIT: It seems like this issue happens only if we want to open NewDot after successful sign-in. I think we might have an issue with ReactNativeActivity start. Perhaps it's not possible to start this activity when app is in background

@mateuuszzzzz
Copy link
Contributor

I confirmed that Android blocks activity start, because app is in background. I'm looking for a fix

@mountiny
Copy link
Contributor

mountiny commented Dec 3, 2024

Nice, great digging!

@mateuuszzzzz
Copy link
Contributor

I managed to find a fix, and I'm preparing a PR so that anyone can verify it. I would also like to test the transition between OD and ND, as well as different scenarios where the app is opened from the background.

@mountiny mountiny closed this as completed Dec 3, 2024
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants