Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authentication APIs to enable HybridApp auth refactor #53556

Open
Julesssss opened this issue Dec 4, 2024 · 8 comments
Open

Update authentication APIs to enable HybridApp auth refactor #53556

Julesssss opened this issue Dec 4, 2024 · 8 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Overdue Weekly KSv2

Comments

@Julesssss
Copy link
Contributor

Problem

I am working with @war-in and @staszekscp on a HybridApp authentication refactor.

They are making good progress but require some backend changes in order to complete the work.

Solution

Update backend APIs to match required onyx data:

we localized three more commands which need to return tryNewDot value

  • SignInWithGoogle
  • SignInWithApple
  • SignInWithShortLivedAuthToken (for SAML)
    We can unify SignInWithShortLivedAuthToken and SinginUser by moving value returned by SignInUser to BeginSignIn.
    We can also simplify the frontend code and return nvp_tryNewDot in the onyxData (like we do for e.g. credentials in BeginSignIn command) so those onyx updates would be handled automatically.

Onyx Data

{
  "onyxData": [
    {
      "onyxMethod": "merge",
      "key": "nvp_tryNewDot",
      "value": {
        "classicRedirect": {
          "dismissed": true/false
        }
      }
    }
  ],
  "jsonCode": 200,
  "requestID": "8ecc27b03b9abbcf-WAW"
}

@Julesssss Julesssss added Engineering Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff labels Dec 4, 2024
@Julesssss Julesssss self-assigned this Dec 4, 2024
@Julesssss Julesssss moved this to MEDIUM in [#whatsnext] #quality Dec 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 9, 2024
@Julesssss
Copy link
Contributor Author

This is lower than other issues in my HybridApp queue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 9, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

@Julesssss Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Julesssss
Copy link
Contributor Author

Finishing up other HybridApp tasks, I should have time for this soon after the new year

@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2024
@Julesssss Julesssss added Weekly KSv2 and removed Daily KSv2 labels Dec 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
@Julesssss
Copy link
Contributor Author

Still waiting for the ability to prioritise

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2025
@Julesssss
Copy link
Contributor Author

The front-end work is in progress.

@melvin-bot melvin-bot bot removed the Overdue label Jan 15, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 23, 2025
@Julesssss
Copy link
Contributor Author

@war-in asked me to provide these changes. I'll be picking up this issue soon.

@melvin-bot melvin-bot bot removed the Overdue label Jan 27, 2025
@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2025
@Julesssss
Copy link
Contributor Author

THis is on my todo list after a fire, and one other HybridApp backend issue.

@melvin-bot melvin-bot bot removed the Overdue label Feb 5, 2025
@melvin-bot melvin-bot bot added the Overdue label Feb 14, 2025
@Julesssss
Copy link
Contributor Author

Aiming to work on this this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Overdue Weekly KSv2
Projects
Status: MEDIUM
Development

No branches or pull requests

1 participant