Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Hybrid App - Spacing above keyboard and status bar overlap on deeplinking to user with no chat #53571

Open
1 of 8 tasks
izarutskaya opened this issue Dec 4, 2024 · 22 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Reviewing Has a PR in review

Comments

@izarutskaya
Copy link

izarutskaya commented Dec 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.71-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5300573
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch Hybrid app
  2. Background the app
  3. Interact with link of an user the account has never chatted with, eg https://staging.new.expensify.com/a/18755827
  4. Tap on message

Expected Result:

Header of the DM should be displayed below device status bar and regular spacing above keyboard should be visible

Actual Result:

There is huge spacing above keyboard, Say hello! message overlap status bar, and the header is not visible.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6684248_1733314550526.Record_2024-12-04-12-55-01.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021864380806227249536
  • Upwork Job ID: 1864380806227249536
  • Last Price Increase: 2024-12-04
Issue OwnerCurrent Issue Owner: @paultsimura
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 4, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 4, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

izarutskaya commented Dec 4, 2024

Added 2 DeployBlocker and DeployBlockerCash becouse it's different behavior
when stg server off and Production

Screen_Recording_20241204_171047_Chrome.mp4
Screen_Recording_20241204_171101_Chrome.mp4
Screen_Recording_20241204_181915_Expensify.mp4

@jasperhuangg
Copy link
Contributor

@izarutskaya It's not clear to me what the regression is. Is the keyboard taking up more space than it needs to?

@izarutskaya
Copy link
Author

@jasperhuangg sorry for confusing, video for some reason not downloaded.

We about the empty space above the keyboard. Updated GH ticket

Screen_Recording_20241204_145106_Expensify.mp4

@jasperhuangg jasperhuangg removed the DeployBlocker Indicates it should block deploying the API label Dec 4, 2024
@jasperhuangg
Copy link
Contributor

Definitely seems like a front-end issue

@jasperhuangg jasperhuangg added the External Added to denote the issue can be worked on by a contributor label Dec 4, 2024
@melvin-bot melvin-bot bot changed the title Hybrid App - Spacing above keyboard and status bar overlap on deeplinking to user with no chat [$250] Hybrid App - Spacing above keyboard and status bar overlap on deeplinking to user with no chat Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021864380806227249536

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

@jasperhuangg jasperhuangg removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Dec 4, 2024
@jasperhuangg
Copy link
Contributor

jasperhuangg commented Dec 4, 2024

This looks like a potential candidate: #53393 Going to try reverting that and making an AdHoc build

EDIT: I don't think an AdHoc build will be testable since it is HybridApp

@jasperhuangg
Copy link
Contributor

Minor display bug, probably not worth blocking deploy on.

@jasperhuangg jasperhuangg added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 4, 2024
@jasperhuangg
Copy link
Contributor

cc @jnowakow this might be related to stuff you're working on, FYI

@jnowakow
Copy link
Contributor

jnowakow commented Dec 5, 2024

@jasperhuangg I'll have a look on it

@jnowakow
Copy link
Contributor

jnowakow commented Dec 5, 2024

@izarutskaya is this a thing that you can reliably reproduce each time?

@jnowakow
Copy link
Contributor

jnowakow commented Dec 6, 2024

@jasperhuangg I forgot to ask you to assign me here. I think I found the solution.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 6, 2024
@jnowakow
Copy link
Contributor

jnowakow commented Dec 6, 2024

Okey I thought I have solution for this one but it solves #53185. But when I try to reproduce this issue I get something like this (it's recording from standalone ND):

ND-main.mov

@jnowakow
Copy link
Contributor

jnowakow commented Dec 6, 2024

It seems that openReport call is duplicated.
duplicated-navigation-after-deeplink-ND.txt

@jnowakow
Copy link
Contributor

@jasperhuangg I'm not able to reproduce it anymore because I'm being navigated to the screen two times. Anyone who I asked doesn't see this behaviour so I suppose it's random problem on my side.
But recently I worked on similar issue and fix just got merged so I believe it may fix this one as well

@mallenexpensify mallenexpensify added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Dec 23, 2024
@mallenexpensify
Copy link
Contributor

Thanks @jnowakow , threw retest-weekly on here, let's see if QA is able to reproduce.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jan 16, 2025
Copy link

melvin-bot bot commented Jan 16, 2025

This issue has not been updated in over 15 days. @mallenexpensify, @jasperhuangg eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants