[HOLD for payment 2025-01-22] [$250] LHN - RBR is missing from the report when it fails to export to QBO

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.74-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5324684&group_by=cases:section_id&group_id=309135&group_order=asc
Issue reported by: Applause Internal Team

Action Performed:

1. https://staging.new.expensify.com/
2. Log in with a new Gmail account
3. Click on FAB - New workspace
4. Enable "Accounting" in the "More features" page.
5. Navigate to "Accounting"
6. Connect to QBO
7. Wait for the sync to finish (refresh the browser if it's stuck at importing data)
8. Navigate to the workspace chat
9. Submit a manual expense with any amount, merchant, and category
10. Pay the expense "elsewhere"
11. Open the expense
12. Click on "Export to QuickBooks Online"
13. Wait a minute and refresh the browser

Expected Result:

RBR should be visible.

Actual Result:

RBR is missing from the report when it fails to export to QBO.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6690691_1733905188166.bandicam_2024-12-11_09-04-56-770.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866980041596226997
• Upwork Job ID: 1866980041596226997
• Last Price Increase: 2025-01-01
• Automatic offers:
• DylanDylann | Reviewer | 105609003

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[joekaufmanexpensify]

Reproduced

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866980041596226997

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[joekaufmanexpensify]

cc @arosiclair as I see you originally implemented this

[arosiclair]

I'll manage this. I might take it internal if I get the cycles.

[joekaufmanexpensify]

TY!

[melvin-bot]

@arosiclair, @joekaufmanexpensify, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[truph01]

I cannot trigger the error "failed to export the report to QuickBooks Online. @joekaufmanexpensify Could you give me a trick to reproduce it, please? Thanks

[joekaufmanexpensify]

@truph01 did you follow the steps in OP of the issue? I had no issue reproducing it with those steps.

[melvin-bot]

@arosiclair, @joekaufmanexpensify, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

[truph01]

@joekaufmanexpensify Yes, I followed the steps and got stuck on the screen below, where the message remains as "started exporting this report to QuickBooks Online..." instead of updating to "failed to export this report..." as mentioned by the OP:

[joekaufmanexpensify]

Interesting. Even after refreshing the browser?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[truph01]

Interesting. Even after refreshing the browser?

Yes

[melvin-bot]

@arosiclair, @joekaufmanexpensify, @thesahindia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[joekaufmanexpensify]

Got it. I'll try reproducing again to make sure I still can.

[joekaufmanexpensify]

I just tried again and could still reproduce it. @truph01 after exporting, try syncing the QBO connection to see if that triggers the error on the report.

[joekaufmanexpensify]

Moving this to weekly for now as I am OOO after today through EOY. If this needs any BZ urgently before then, please ask in Slack. Otherwise, I will continue to assist when I return.

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[pac-guerreiro]

@DylanDylann @arosiclair @IuliiaHerets @joekaufmanexpensify

I just opened a PR with the fix for this issue 😄

[pac-guerreiro]

Today I dedicated my time to write unit tests for this PR but I haven't finished them yet.

[pac-guerreiro]

PR was merged! 🚀

Thanks @DylanDylann and @arosiclair 😄

[joekaufmanexpensify]

Wooo, TY!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• LHN - RBR is missing from the report when it fails to export to QBO #54981

If no regressions arise, payment will be issued on 2025-01-22. 🎊

For reference, here are some details about the assignees on this issue:

• @pac-guerreiro does not require payment (Contractor)
• @DylanDylann requires payment automatic offer (Reviewer)

[melvin-bot]

@DylanDylann @joekaufmanexpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[joekaufmanexpensify]

@DylanDylann could you handle checklist here? TY!

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: No need, because the author of previous PR fixed this problem

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

1. Log in with a new Gmail account
2. Click on FAB - New workspace
3. Enable "Accounting" in the "More features" page.
4. Navigate to "Accounting"
5. Connect to QBO
6. Wait for the sync to finish (refresh the browser if it's stuck at importing data)
7. Navigate to the workspace chat
8. Submit a manual expense with any amount, merchant, and category
9. Pay the expense "elsewhere"
10. Open the expense
11. Click on "Export to QuickBooks Online"
12. Wait a minute and refresh the browser
13. RBR should be visible on LHN

Do we agree 👍 or 👎

[joekaufmanexpensify]

No new test needed. I checked in test rail and this case is already covered by https://expensify.testrail.io/index.php?/cases/view/3284910&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=309135

[joekaufmanexpensify]

All set for payment! Only payment here is $250 to @DylanDylann for C+ review via upwork.

[joekaufmanexpensify]

@DylanDylann $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set, thanks everyone!