[HOLD for payment 2025-02-04] [Tracking Issue] Fixes to Implemented International Bank Account flow

[Beamanator]

This big PR has lots of little issues we need to fix. Tracking them here so we can try to keep them all in 1 place & note what the next steps are for each

cc @shubham1206agra @DylanDylann @MonilBhavsar

[shubham1206agra]

Still marked as blockers - now need to be tested to see if they're fixed in staging:

• Bank Account - User does not land back on the country selector after closing the plaid UI. #54737
• Wallet - Error indicating a selection is required is not shown in account selection page #54738
• Wallet - Corpay error message is not shown for invalid account and Swift Code #54745
• Wallet - Bank name and account holder name fields accept emoji as name #54752
• Wallet - Country list does not auto scroll up when showing search result #54757

Issues marked NAB - probably can close them all, but need to be addressed before next mega PR is merged:

• Wallet - Error message indicates "swift code" as "routing number" #54711 - BE Fix
• Wallet - Bank account subtitle shows undefined after adding bank account #54707 - BE fix
• [$250] Wallet - Excluded countries and their currencies are shown #54741
• Wallet - Account number field shows two error messages when it is empty #54692 - Discussion happening in Wallet - Account number field shows two error messages when it is empty #54692 (comment)
• Wallet - Selected account type is not shown after returning back #54739
• Wallet - Currency does not auto update after changing country #54694
• [$250] Wallet -Order of bank & account holder fields is different on individual page and confirm page #54709
• Wallet - Checkbox on confirmation page becomes unchecked after returning from field editor #54720
• [$250] Wallet - Prior bank account detail inputs are not shown. #54740
• [$250] Wallet - In offline mode, no full blocking view in country page, country & currency are editable #54746
• Wallet - The top of the confirmation page header is not “Check your info.” #54749
• Wallet - Error for invalid IBAN should be "Invalid IBAN" instead of "400 invalid IBAN" #54751
• Wallet - Account number field is not focused #54742
• Wallet - Make default payment method option uses a message icon instead of star icon #54750

[Julesssss]

Happy 2025, here's another bug to fix, I added it to the list above: #54746

[Beamanator]

Reverted the big PR (#54729), will CP soon after making sure it didn't break everything

[parasharrajat]

We can start closing the related issues in that case.

[Beamanator]

Yeah once it's CP'd 🙏

[Beamanator]

Ok so the revert CP was successful, in 9.0.80.6

I'm going to ask QA to help test all of the issues on this list, starting with the blockers, to at least help us unblock the deploy

[Beamanator]

Once each is confirmed fix / not reproducible in staging, we can check them of the list above.

Finally, @shubham1206agra will be working on making sure none exist in his next PR (looks like the draft was started above)

[izarutskaya]

#54737 - found issue - #52199
#54738 - issue #52199
#54740 - issue #52199
#54746 - found issue #54767
#54749 - issue #52199
#54751 - issue #52199
#54742 - issue #52199
#54692 - pending on Web

[izarutskaya]

#54692 - all slots are passed. Checking off

[shubham1206agra]

@MonilBhavsar Can you close all the issues? Since I will keep track of these through this tracker.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Implemented International Bank Account flow #54798

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)

[shubham1206agra]

• Bank Account - User does not land back on the country selector after closing the plaid UI. #54737 - a060234
• Wallet - Error indicating a selection is required is not shown in account selection page #54738 - 6b982b3
• Wallet - Corpay error message is not shown for invalid account and Swift Code #54745 - Not a bug as per comment
• Wallet - Bank name and account holder name fields accept emoji as name #54752 - BE issue
• Wallet - Country list does not auto scroll up when showing search result #54757 - da88626
• Wallet - Error message indicates "swift code" as "routing number" #54711 - BE issue
• Wallet - Bank account subtitle shows undefined after adding bank account #54707 - BE issue
• [$250] Wallet - Excluded countries and their currencies are shown #54741 - c07ec58
• Wallet - Account number field shows two error messages when it is empty #54692 - 3cddf30
• Wallet - Selected account type is not shown after returning back #54739 - 300a666
• Wallet - Currency does not auto update after changing country #54694 - ca22f9b
• [$250] Wallet -Order of bank & account holder fields is different on individual page and confirm page #54709 - d9e53a9
• Wallet - Checkbox on confirmation page becomes unchecked after returning from field editor #54720 - d88fe50
• [$250] Wallet - Prior bank account detail inputs are not shown. #54740 - d88fe50
• [$250] Wallet - In offline mode, no full blocking view in country page, country & currency are editable #54746 - cef7c93
• Wallet - The top of the confirmation page header is not “Check your info.” #54749 - 976956e
• Wallet - Error for invalid IBAN should be "Invalid IBAN" instead of "400 invalid IBAN" #54751 - BE issue
• Wallet - Account number field is not focused #54742
• Wallet - Make default payment method option uses a message icon instead of star icon #54750 - 13a8197

[MonilBhavsar]

Thanks for handing this! I think we can close this as payment will be handled in the main issue