Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on "Let's go" shows "Hmm... it's not here" #54942

Closed
2 of 8 tasks
IuliiaHerets opened this issue Jan 8, 2025 · 11 comments
Closed
2 of 8 tasks

Clicking on "Let's go" shows "Hmm... it's not here" #54942

IuliiaHerets opened this issue Jan 8, 2025 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.82-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #54921
Issue reported by: Applause Internal Team
Device used: Android 13/ Chrome
App Component: Other

Action Performed:

  1. Sign into a new account in OldDot
  2. Run: NVP.set('tryNewDot', {classicRedirect: {dismissed: true, completedHybridAppOnboarding: false}, nudgeMigration: {timestamp: '2024-01-07'}});
  3. Sign into the same account on NewDot
  4. The "Welcome to Expensify" modal should not be seen.
  5. Reload the page
  6. Make sure you see the "Travel and expense, at the speed of chat" modal
  7. Click "Let's go!" on" Travel and expense, at the speed of chat" modal

Expected Result:

the "Welcome to Expensify" modal should not load and the "Hmm... it's not here" should not show up.

Actual Result:

Hmm.. it's not here page shows up when clicking on let's go in "Travel and expense, at the speed of chat" modal

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6708717_1736306046520.video_2025-01-08_06-04-01.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jan 8, 2025
Copy link

melvin-bot bot commented Jan 8, 2025

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 8, 2025

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 8, 2025
Copy link

melvin-bot bot commented Jan 8, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@joekaufmanexpensify
Copy link
Contributor

I can't reproduce on web. Trying on android mWeb.

2025-01-08_11-53-31.mp4

@joekaufmanexpensify
Copy link
Contributor

I also can't reproduce on android.

2025-01-08_11-58-32.mp4

@joekaufmanexpensify
Copy link
Contributor

  1. Sign into the same account on NewDot
  2. The "Welcome to Expensify" modal should not be seen.
  3. Reload the page
  4. Make sure you see the "Travel and expense, at the speed of chat" modal
  5. Click "Let's go!" on" Travel and expense, at the speed of chat" modal

Step 4 here did not occur for me. After setting the NVP in OldDot, I see the "Travel and expense, at the speed of chat" modal on my first sign in to NewDot and clicking lets go dismissed it without showing the "hmm, not here" page.

@joekaufmanexpensify
Copy link
Contributor

@Julesssss curious for your thoughts here too or if you can reproduce this.

@aldo-expensify
Copy link
Contributor

Same, failed to reproduce:

image

I'll remove the DeployBlocker label to continue with the web deploy. This doesn't look related to the backend.

@aldo-expensify aldo-expensify removed the DeployBlocker Indicates it should block deploying the API label Jan 8, 2025
@kavimuru
Copy link

kavimuru commented Jan 8, 2025

Bug is fixed now.

macOS.Sequoia.15.2._.Chrome.mp4

@joekaufmanexpensify
Copy link
Contributor

Sweet. Going to close this then, as it seems like this is no longer an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants