$250 Track expense - Learn more in Upgrade modal opens not here page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.84-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new Gmail account.
3. Select "Track and budget expenses" during onboarding.
4. Complete the onboarding.
5. Go to self DM.
6. Track an expense.
7. Click Categorize it.
8. Click Learn more link.

Expected Result:

Learn more will open a valid page.

Actual Result:

Learn more in Upgrade modal opens not here page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6711583_1736571333749.20250111_115707.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[techievivek]

This will be fixed here: #55110, so removing the blocker label and keeping it open until we have confirmed the fix.

[Beamanator]

@techievivek it also seems like #55117 is linked to fix this PR, is that correct or maybe no?

[techievivek]

That's correct, forgot to link the convo https://expensify.slack.com/archives/C01GTK53T8Q/p1736594963901249?thread_ts=1736581034.662169&cid=C01GTK53T8Q

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.84-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Subscription plan card UI changes #55117

If no regressions arise, payment will be issued on 2025-01-21. 🎊

[melvin-bot]

@techievivek @michaelkwardrop @techievivek The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Subscription plan card UI changes #55117

If no regressions arise, payment will be issued on 2025-01-22. 🎊

[melvin-bot]

@techievivek @michaelkwardrop @techievivek The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[michaelkwardrop]

@techievivek are we good to close? ✨

[mallenexpensify]

@DylanDylann , it looks like you reviewed the PR, for the TestRail test case, are the below the correct steps?

Test 1

1. Go to staging.new.expensify.com
2. Log in with a new Gmail account (no workspace).
3. Select "Track and budget expenses" during onboarding.
4. Complete the onboarding.
5. Go to self DM.
6. Track an expense.
7. Click Categorize it.
8. Veify that button in the upgrade modal should be "Upgrade" which allows user to directly create a new Collect workspace.

Test 2

1. Go to staging.new.expensify.com
2. Log in with a new account.
3. Create a workspace.
4. Go to Subscription tab.
5. Click on the empty space under Control plan content within the box.
6. Verify tha empty space under Control plan content within the box should respond to click.

Test 3

1. Go to staging.new.expensify.com
2. Log in with a new account.
3. Create a workspace.
4. Go back to Settings.
5. Go to Subscription tab.
6. Verify that Control plan modal will have bottom padding.

[DylanDylann]

@mallenexpensify I think we only need to add test 1. Test 2, test 3 are unnecessary

Test 1

Go to staging.new.expensify.com
Log in with a new Gmail account (no workspace).
Select "Track and budget expenses" during onboarding.
Complete the onboarding.
Go to self DM.
Track an expense.
Click Categorize it.
Veify that button in the upgrade modal should be "Upgrade" which allows user to directly create a new Collect workspace.

[michaelkwardrop]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[michaelkwardrop]

@DylanDylann looks like you need to be paid for this still! Can you fill out the Checklist above?

I am not seeing this tied to any regressions caused by your contributions, right? I want to make sure I pay you the right amount! I'm new to the BugZero team so please forgive my clunkiness on these first few.

[DylanDylann]

@michaelkwardrop No, we should close this one

[DylanDylann]

For this issue only, I don't think we need any regression test

[melvin-bot]

@techievivek @DylanDylann @michaelkwardrop this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[michaelkwardrop]

Thanks @DylanDylann! I'll close this one out.