Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-28] Update the direct bank connection flow on desktop #55161

Closed
mountiny opened this issue Jan 13, 2025 · 8 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Jan 13, 2025

Problem

Coming from here, the desktop bank connection flow is not very smooth and leads to not found page on the webview. The connection is successful, but the UI is confusing.

Solution

Let's match the accounting connection flow behaviour and make sure that the web page is not showing not found page after connecting, but rather show the connection complete ui:

Image

Issue OwnerCurrent Issue Owner: @bfitzexpensify
@mountiny mountiny added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 13, 2025
@mountiny mountiny self-assigned this Jan 13, 2025
Copy link

melvin-bot bot commented Jan 13, 2025

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@VickyStash
Copy link
Contributor

Updates:
I haven't made big progress on this one today as I was focused on other issues. But I plan to do some work on it tomorrow!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 14, 2025
@VickyStash
Copy link
Contributor

The PR has been opened for the review!
@mountiny I've left you a small question.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 21, 2025
@melvin-bot melvin-bot bot changed the title Update the direct bank connection flow on desktop [HOLD for payment 2025-01-28] Update the direct bank connection flow on desktop Jan 21, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 21, 2025
Copy link

melvin-bot bot commented Jan 21, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-28. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 21, 2025

@mountiny @bfitzexpensify @VickyStash The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 27, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@github-project-automation github-project-automation bot moved this from In Progress to Done in [#whatsnext] #convert Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Development

No branches or pull requests

3 participants