Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-13] [$250] Android - Track expense - Error when creating track scan expense from Quick action #55240

Closed
2 of 8 tasks
IuliiaHerets opened this issue Jan 14, 2025 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 14, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.85-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): Samsung Galaxy Z Fold 4 / Android 14
Issue reported by: Applause Internal Team
Device used: [email protected]
App Component: Money Requests

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to self DM.
  3. Create a track scan expense.
  4. Go back to LHN.
  5. Open FAB.
  6. Tap Track receipt under Quick action.
  7. Upload a receipt and submit.
  8. Go back to LHN.

Expected Result:

The second track scan expense should remain in self DM when created from Quick action.

Actual Result:

The second track scan expense disappeas from self DM after it is created from Quick action.
It appears as an error report with RBR in LHN.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6714224_1736884791029.Screen_Recording_20250115_035537_Media_picker.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021882503761567985375
  • Upwork Job ID: 1882503761567985375
  • Last Price Increase: 2025-01-23
Issue OwnerCurrent Issue Owner: @VictoriaExpensify
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 14, 2025
Copy link

melvin-bot bot commented Jan 14, 2025

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@jacobkim9881
Copy link
Contributor

jacobkim9881 commented Jan 15, 2025

#54628

On android, receipt image isn't instanceof Blob so the receipt is changed into undefined

receipt: trackedReceipt instanceof Blob ? trackedReceipt : undefined,

@CyberAndrii could you please to check?

@CyberAndrii
Copy link
Contributor

Thanks @jacobkim9881. We will need another PR for this @Pujan92.

Why does it work when tracking via FAB but not QAB 😕

@jacobkim9881
Copy link
Contributor

@CyberAndrii Sad to notice this 😕 Good for you to fix this tho

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 16, 2025
Copy link

melvin-bot bot commented Jan 23, 2025

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@deetergp deetergp added the External Added to denote the issue can be worked on by a contributor label Jan 23, 2025
@melvin-bot melvin-bot bot changed the title Android - Track expense - Error when creating track scan expense from Quick action [$250] Android - Track expense - Error when creating track scan expense from Quick action Jan 23, 2025
Copy link

melvin-bot bot commented Jan 23, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021882503761567985375

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 23, 2025
Copy link

melvin-bot bot commented Jan 23, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 23, 2025
@jacobkim9881
Copy link
Contributor

I think this will be solved as #55321 is merged.

Copy link

melvin-bot bot commented Jan 31, 2025

@deetergp, @VictoriaExpensify, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Feb 4, 2025

@deetergp, @VictoriaExpensify, @getusha 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@deetergp
Copy link
Contributor

deetergp commented Feb 4, 2025

Looks like this was merged and deployed to staging. I have asked for a retest in our QA channel here https://expensify.slack.com/archives/C9YU7BX5M/p1738687602185819

@m-natarajan
Copy link

Issue fixed

1738661568715.55321_Android.mp4

@deetergp
Copy link
Contributor

deetergp commented Feb 4, 2025

Thank you @m-natarajan. Closing this one out.

@deetergp deetergp closed this as completed Feb 4, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 6, 2025
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Feb 6, 2025
@melvin-bot melvin-bot bot changed the title [$250] Android - Track expense - Error when creating track scan expense from Quick action [Due for payment 2025-02-13] [$250] Android - Track expense - Error when creating track scan expense from Quick action Feb 6, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 6, 2025
Copy link

melvin-bot bot commented Feb 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-13. 🎊

For reference, here are some details about the assignees on this issue:

  • @getusha requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Feb 6, 2025

@getusha @VictoriaExpensify @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants