PR54352-Room-The "Schedule a demo" button is not displayed in the #admin room

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.88-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54352
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung S23FE/ Android 14
App Component: Other

Action Performed:

Precondition:
The account should be validated for login in the Hybrid Android app.

Steps:

1. Login with new account (without +)
2. Complete onboarding workflow
3. Create a new workspace
4. Go to admin room

Expected Result:

The "Schedule a demo" button is displayed in the header of the #admin room.

Actual Result:

The "Schedule a demo" button is not displayed in the header of the #admin room.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6720292_1737491267252.54352-Android.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

@techievivek We defined the type of adminsRoomReportID in account as a string but the backend returns it as number.

Then this condition doesn't match.

App/src/pages/home/HeaderView.tsx

Line 153 in 73f2714

const shouldShowGuideBooking = !!account && report?.reportID === account?.adminsRoomReportID && !!account?.guideDetails?.calendarLink;

Can you change backend to return the string instead of the number for adminsRoomReportID and accountManagerReportID in GetAssignedSupportData API because normal all reportIDs in the App has string type.

[techievivek]

@nkdengineer Interesting, but why is this bug showing up now? We merged that PR long back no?

[nkdengineer]

@techievivek I just created a PR #55521 that removed the toString method when comparing then it happens.

[techievivek]

We will need to wait for the auth deploy here, I have pushed the PR. https://github.com/Expensify/Auth/pull/13911

[techievivek]

I think we can remove the blocker label from this since we need changes from Auth and Web-e both to be deployed before we can close it out. @Beamanator what do you think?

[Beamanator]

I think that's fair! The button is not a super critical bug so if we're only missing a button, nothing else broken, i think let's go NAB here 👍

[joekaufmanexpensify]

Seems like multiple PRs merged/in review. So moving to weekly for now!

[joekaufmanexpensify]

Web PR is merged and out to prod. Auth PR merged and pending deploy. This will be all set after the next auth deploy!

[joekaufmanexpensify]

No payment needed here as @nkdengineer and @eh2077 app PR here was fixing a deploy blocker from another PR they worked on.

[joekaufmanexpensify]

Auth PR deployed last night!

[joekaufmanexpensify]

Closing as we should be all set here. Thanks everyone!