Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONST.DEFAULT_NUMBER_ID case to no-default-id-values ESLint rule #55814

Open
fabioh8010 opened this issue Jan 27, 2025 · 5 comments
Open

Add CONST.DEFAULT_NUMBER_ID case to no-default-id-values ESLint rule #55814

fabioh8010 opened this issue Jan 27, 2025 · 5 comments
Assignees
@fabioh8010 @thienlnam
Labels
Monthly KSv2

Comments

@fabioh8010
Copy link
Contributor

Context: https://expensify.slack.com/archives/C01GTK53T8Q/p1737913879440099
@fabioh8010 fabioh8010 mentioned this issue Jan 27, 2025
Merged
@fabioh8010
Copy link
Contributor Author

PR opened to review

@fabioh8010
Copy link
Contributor Author

PR merged, will prepare the E/App one

@fabioh8010 fabioh8010 mentioned this issue Jan 27, 2025
Open
@fabioh8010
Copy link
Contributor Author

@thienlnam

@VickyStash is working on this PR to remove these wrong defaultings to CONST.DEFAULT_NUMBER_ID, so we thought we could upgrade the eslint-config-expensify version in her PR too. WDYT?

@thienlnam
Copy link
Contributor

Yeah that sounds good

@thienlnam thienlnam mentioned this issue Jan 28, 2025
Merged
50 tasks
@VickyStash
Copy link
Contributor

I've bumped the eslint-config-expensify version in the PR!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jan 31, 2025
@Pujan92 Pujan92 mentioned this issue Feb 4, 2025
Merged
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabioh8010 fabioh8010

@thienlnam thienlnam

Labels
Monthly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabioh8010 @VickyStash @thienlnam