Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track expense - Back button returns to the same workspace chat after deleting track expense #56321

Closed
6 of 8 tasks
IuliiaHerets opened this issue Feb 4, 2025 · 7 comments
Closed
6 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #56073
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Money Requests

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to self DM.
  3. Submit a manual expense to the self DM.
  4. Tap Share it with my accountant.
  5. Select a workspace.
  6. Enter merchant and submit the expense.
  7. Close the invite sheet.
  8. Tap on the expense preview.
  9. Tap on the report header > Delete expense.
  10. Delete the expense.
  11. Tap app back button.

Expected Result:

App will return to self DM.

Actual Result:

App returns to the same workspace chat.
Only the second tap on the back button returns app to the self DM.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6732993_1738664512753.ScreenRecording_02-04-2025_18-17-59_1.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Expense can't be deleted on production

XRecorder_04022025_133323.mp4

@blimpich
Copy link
Contributor

blimpich commented Feb 4, 2025

Kind of a minor bug, not sure if this is worth blocking deploy on. Looks related to this PR: #55015

@puneetlath
Copy link
Contributor

We reverted the offending PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants