Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Add Debit Card page to use VBA styles and fix misaligned state/zip fields #5644

Closed
kavimuru opened this issue Oct 4, 2021 · 10 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Oct 4, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue was found when executing #4405

Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Open your settings
  4. Open the "Payments" page
  5. Tap the option "Debit Card" under "Add Payment Method"
  6. Verify the "Add Debit Card" page

Expected Result:

There should be no misalignments observed in the page

Actual Result:

State and Zip code boxes are not aligned.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.5-0
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Oct 4, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Oct 4, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Jag96
Copy link
Contributor

Jag96 commented Oct 5, 2021

The link issue looks like it was initially reported here, @jasperhuangg looks like you had some context on that. Regarding the form field alignment, it looks like this form isn't using the same form components that we use for the VBA flow:

Add Debit Card VBA
image

It looks like the original issue for this page included old screenshots, so not sure if this is supposed to have different form fields (cc @stitesExpensify).

@isagoico
Copy link

isagoico commented Oct 5, 2021

Updated the original comment to reflect only the State and Zip code fields misalignment issue

@isagoico isagoico changed the title iOS/ Android - Add Debitcard - Misalignment of text and hyperlink also state and Zipcode fields iOS/ Android - Add Debitcard - Misalignment state and Zipcode fields Oct 5, 2021
@Jag96 Jag96 mentioned this issue Oct 5, 2021
5 tasks
@chiragsalian
Copy link
Contributor

Jasper is OOO. Since its just a minor visual bug i'll be removing the deploy blocker and hourly label. Setting it to daily with the expectation that @rdjuric addresses the issue soon. Reassigning issue to @rdjuric. Please try to address it at the earliest.

@mvtglobally
Copy link

Issue reproducible during KI retests.

@Jag96
Copy link
Contributor

Jag96 commented Oct 12, 2021

Going to pick this one up to update the add debitcard page to use the same form elements as our other forms

@Jag96 Jag96 self-assigned this Oct 12, 2021
@mvtglobally
Copy link

Issue reproducible during KI retests.

@Jag96 Jag96 changed the title iOS/ Android - Add Debitcard - Misalignment state and Zipcode fields Update Add Debit Card page to use VBA styles and fix misaligned state/zip fields Oct 18, 2021
@Jag96 Jag96 added the Improvement Item broken or needs improvement. label Oct 19, 2021
@Jag96
Copy link
Contributor

Jag96 commented Oct 25, 2021

WIP PR above has the latest todos, this is not overdue

@MelvinBot MelvinBot removed the Overdue label Oct 25, 2021
@Jag96 Jag96 added the Reviewing Has a PR in review label Oct 26, 2021
@mvtglobally
Copy link

Issue reproducible during KI retests.

@botify botify closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants