-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Add Debit Card page to use VBA styles and fix misaligned state/zip fields #5644
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @jasperhuangg ( |
The link issue looks like it was initially reported here, @jasperhuangg looks like you had some context on that. Regarding the form field alignment, it looks like this form isn't using the same form components that we use for the VBA flow:
It looks like the original issue for this page included old screenshots, so not sure if this is supposed to have different form fields (cc @stitesExpensify). |
Updated the original comment to reflect only the State and Zip code fields misalignment issue |
Issue reproducible during KI retests. |
Going to pick this one up to update the add debitcard page to use the same form elements as our other forms |
Issue reproducible during KI retests. |
WIP PR above has the latest todos, this is not overdue |
Issue reproducible during KI retests. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue was found when executing #4405
Action Performed:
Expected Result:
There should be no misalignments observed in the page
Actual Result:
State and Zip code boxes are not aligned.
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.5-0
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: