[Due for payment 2025-02-19] Reports - Chat name is not wrapped properly when report name is long and has no limit

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Search

Action Performed:

1. Launch ND or hybrid app.
2. Go to DM.
3. Send a long message with some spaces between words.
4. Long tap on the message > Reply in thread.
5. Send a reply in thread.
6. Go to Reports.
7. Tap on the dropdown.
8. Select Chats.

Expected Result:

• When the report name is long, the line should be wrapped correctly.
• Long room name should be limited to two lines.

Actual Result:

• When the report name is long, the line is not wrapped correctly.
• Long room name is not limited to a few lines.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/c88b1c2e-4daa-41af-be4b-a4eaa47d4561

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021887868925117012182
• Upwork Job ID: 1887868925117012182
• Last Price Increase: 2025-02-07
• Automatic offers:
• DylanDylann | Reviewer | 106038637

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the report name is long, the line is not wrapped correctly.
Long room name is not limited to a few lines.

What is the root cause of that problem?

We don't pass numberOfLines to this text link

App/src/components/SelectionList/ChatListItem.tsx

Lines 106 to 111 in 33a03bf

	<TextLink
	fontSize={variables.fontSizeSmall}
	onPress={() => onSelectRow(item)}
	>
	{reportActionItem.reportName}
	</TextLink>

What changes do you think we should make in order to solve the problem?

We should add props numberOfLines={2}

App/src/components/SelectionList/ChatListItem.tsx

Lines 106 to 111 in 33a03bf

	<TextLink
	fontSize={variables.fontSizeSmall}
	onPress={() => onSelectRow(item)}
	>
	{reportActionItem.reportName}
	</TextLink>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[NJ-2020]

Regression PR: #50135

[techievivek]

An edge case IMO, so we can remove the blocker label and let the author fix this as a followup.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021887868925117012182

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[techievivek]

I don't think we need to have any compensation here since it's a followup to another PR they worked on #50135

[zfurtak]

Hi, can you assign me? I’ll take care of it today :)

[DylanDylann]

The PR was merged

[dylanexpensify]

Beautiful!

[Julesssss]

@luacmartins do you recall what happened here?

• @techievivek triaged and removed the label
• You mentioned another PR (this was merged but NOT deployed)
• You re-added deploy blocker label

I think maybe the label got added incorrectly and we don't need to do anything here? Or do you want me to CP the mentioned PR?

[luacmartins]

@Julesssss yea, I re-added the label, but it seems like the PR was checked off the checklist and I didn't uncheck it, so we deployed the bug. It was a small one and a bit of an edge case, so no big deal. Now that the bug is deployed, we can wait for regular deploy cycles to get the merged PR in prod as well.

[Julesssss]

Thanks, sounds good.

[dylanexpensify]

Moving along

[luacmartins]

The fix is on staging and there's no payment needed on this once since it was a bug introduced by #50135, so we can close this issue once the PR hits production.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.97-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make the name wrapped when it's too long #56591

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @zfurtak does not require payment (Contractor)
• @DylanDylann requires payment automatic offer (Reviewer)

[melvin-bot]

@DylanDylann @dylanexpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dylanexpensify]

Payment summary:

Contributor+: @DylanDylann $250 via NewDot

Please apply/request!

[DylanDylann]

@dylanexpensify I still get paid via Upwork

[DylanDylann]

But this issue isn't required payment

[DylanDylann]

It is a regression. Let's close this one

[luacmartins]

Closing!