Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Reports - Expense report is opened for a second time when paying the expense. #56729

Open
1 of 8 tasks
mitarachim opened this issue Feb 12, 2025 · 16 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Feb 12, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.97-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12
App Component: Money Requests

Action Performed:

  1. Open the Expensify app.
  2. Open any workspace chat.
  3. Tap on the "+" button and select "Create Expense"
  4. Complete the expense creation flow.
  5. Return to inbox and tap on "Reports" on the bottom of the screen.
  6. Open the just created expense.
  7. Tap on "Pay Elsewhere"
  8. Check if the expense is displayed as paid in the report, or if another window is opened with the same report.
  9. Tap on the arrow on the top left corner to return to expenses list.
  10. Check if you are navigated to expenses list or if you were redirected to expense report again.

Expected Result:

When an expense is paid, the report should be updated, showing this last action without opening the report again on a different window.

Actual Result:

Expense report is opened for a second time on a different window, when paying the expense on reports section. After this, the user has to tap on the back button twice to return to expenses list.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6740243_1739332497074.Payment.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021889627593367844154
  • Upwork Job ID: 1889627593367844154
  • Last Price Increase: 2025-02-12
  • Automatic offers:
    • nkdengineer | Contributor | 106094683
Issue OwnerCurrent Issue Owner: @Pujan92
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 12, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 12, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny
Copy link
Contributor

I cannot see any PR from the checklist that might cause this

@techievivek
Copy link
Contributor

Maybe something from backend? Since we have seen such bugs in past?

@techievivek
Copy link
Contributor

Let me inspect the request.

@mountiny
Copy link
Contributor

Here its navigation related, I would expect App bug. @adamgrzybowski are you able to reproduce in staging?

I think you had to fix last minute some bugs with goBack in your branch - maybe this has similar rootcause

@techievivek
Copy link
Contributor

Yeah, it could be related to navigation too, since the button goes pack to paid state.

@pasyukevich
Copy link
Member

Hi, I'm Eugene from Callstack - expert contributor group. I’d like to work on this issue.

@techievivek
Copy link
Contributor

I am demoting this since the state eventually returns back to a paid state, and in no way does it prevent users from paying for a money request. Also though we have the fix for this regression we can't CP it as it's a bit tricky situation, discussions here https://expensify.slack.com/archives/C01GTK53T8Q/p1739357123017289?thread_ts=1739335771.174889&cid=C01GTK53T8Q

@techievivek techievivek added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 12, 2025
@melvin-bot melvin-bot bot changed the title Android - Reports - Expense report is opened for a second time when paying the expense. [$250] Android - Reports - Expense report is opened for a second time when paying the expense. Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021889627593367844154

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 12, 2025
@nkdengineer
Copy link
Contributor

@techievivek I'm here.

Copy link

melvin-bot bot commented Feb 12, 2025

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 12, 2025
@nkdengineer
Copy link
Contributor

@rayane-d The PR is ready for review.

@dylanexpensify dylanexpensify moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

8 participants