Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation][Not here] Workspace - Using device back button after deleting workspace, leads to "It´s not here" page #56813

Open
2 of 8 tasks
IuliiaHerets opened this issue Feb 13, 2025 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 13, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Workspace Settings

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Tap on "Settings" and select "Workspaces"
  3. Open any workspace.
  4. Tap on "Overview"
  5. Tap on "Delete" and confirm the workspace deletion.
  6. Once redirected to workspaces list, use device back button.
  7. Check the app behavior with this action.

Expected Result:

When using the device back button after deleting a workspace, the user should land on "Settings"

Actual Result:

User lands on "It´s not here" page when using device´s back button after deleting a workspace.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6741477_1739420956524.Error.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @adamgrzybowski
@IuliiaHerets IuliiaHerets added Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 13, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 13, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny assigned mountiny and unassigned mjasikowski Feb 13, 2025
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 13, 2025
@mountiny mountiny changed the title Workspace - Using device back button after deleting workspace, leads to "It´s not here" page [Navigation] Workspace - Using device back button after deleting workspace, leads to "It´s not here" page Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor

Demoting as it seems very minor. Its related to recent navigation changes and we will handle it with the SWM team as a follow up https://expensify.slack.com/archives/C01GTK53T8Q/p1739328522587109

@melvin-bot melvin-bot bot added the Overdue label Feb 17, 2025
@mountiny
Copy link
Contributor

Will post a summary for SWM with all the issues so they can distrubute them

@melvin-bot melvin-bot bot removed the Overdue label Feb 17, 2025
@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Feb 17, 2025
@mountiny
Copy link
Contributor

@adamgrzybowski
Copy link
Contributor

👋

@isabelastisser
Copy link
Contributor

hey @adamgrzybowski, can you please provide an update? Are you working on a proposal/PR?

Copy link

melvin-bot bot commented Feb 21, 2025

@isabelastisser, @mountiny, @shubham1206agra, @adamgrzybowski, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Feb 21, 2025
@melvin-bot melvin-bot bot removed the Overdue label Feb 21, 2025
@mountiny
Copy link
Contributor

Making this weekly, Adam is ooo and we want to make sure the solution is holistic enough so gonna wait for them

@mallenexpensify mallenexpensify changed the title [Navigation] Workspace - Using device back button after deleting workspace, leads to "It´s not here" page [Navigation][Not here] Workspace - Using device back button after deleting workspace, leads to "It´s not here" page Feb 26, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

@isabelastisser @mountiny @shubham1206agra @adamgrzybowski @dukenv0307 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: MEDIUM
Development

No branches or pull requests

7 participants