Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-25] [$125] iOS - Distance - FAB menu appears briefly when closing distance receipt view #56814

Closed
2 of 8 tasks
IuliiaHerets opened this issue Feb 13, 2025 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 13, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Money Requests

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to FAB > Create expense > Distance.
  3. Enter waypoints > Next.
  4. Tap Destination field and select user or workspace with no unsettled expense (or directly select user or workspace with no unsettled expense).
  5. Submit the distance expense.
  6. In the main chat, tap on the expense preview.
  7. Tap on the distance receipt.
  8. Tap app back button.

Expected Result:

FAB menu will not appear when closing distance receipt view.

Actual Result:

FAB menu appears briefly when closing distance receipt view

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6741522_1739425709065.ScreenRecording_02-13-2025_13-42-29_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021889967614492412875
  • Upwork Job ID: 1889967614492412875
  • Last Price Increase: 2025-02-13
Issue OwnerCurrent Issue Owner: @CortneyOfstad
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 13, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 13, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 13, 2025

💬 A slack conversation has been started in #expensify-open-source

@lakchote
Copy link
Contributor

lakchote commented Feb 13, 2025

Not a blocker, it's a minor UI bug.

@lakchote lakchote added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 13, 2025
@melvin-bot melvin-bot bot changed the title iOS - Distance - FAB menu appears briefly when closing distance receipt view [$250] iOS - Distance - FAB menu appears briefly when closing distance receipt view Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021889967614492412875

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

@mountiny mountiny changed the title [$250] iOS - Distance - FAB menu appears briefly when closing distance receipt view [$125] iOS - Distance - FAB menu appears briefly when closing distance receipt view Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Upwork job price has been updated to $125

@mountiny
Copy link
Contributor

Making this half the price as its really minor. Might be related to our navigation changes, that we are discussing here https://expensify.slack.com/archives/C01GTK53T8Q/p1739328522587109 if that helps for anyone

@zirgulis
Copy link
Contributor

Hi I'm Povilas from Callstack and I would like to work on this issue,

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 13, 2025
@lakchote
Copy link
Contributor

Hi I'm Povilas from Callstack and I would like to work on this issue,

Thanks @zirgulis, I've assigned you.

@bernhardoj
Copy link
Contributor

I think #56852 has a similar issue

@zirgulis
Copy link
Contributor

Not reproducible on latest main, I think this PR fixed it #56865

@nkdengineer
Copy link
Contributor

Yes, it fixed this issue.

@CortneyOfstad
Copy link
Contributor

Closing this out as it appears to be fixed! Thanks all!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Feb 18, 2025
@melvin-bot melvin-bot bot changed the title [$125] iOS - Distance - FAB menu appears briefly when closing distance receipt view [Due for payment 2025-02-25] [$125] iOS - Distance - FAB menu appears briefly when closing distance receipt view Feb 18, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-25. 🎊

For reference, here are some details about the assignees on this issue:

  • @ntdiary requires payment through NewDot Manual Requests
  • @zirgulis does not require payment (Contractor)

Copy link

melvin-bot bot commented Feb 18, 2025

@ntdiary @CortneyOfstad @ntdiary The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants