[Due for payment 2025-02-25] QBO - The app does not redirects to the Export page after a value is selected

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #49539
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Workspace Settings

Action Performed:

Precondition: Workspace with QBO integration connected.

1. https://staging.new.expensify.com/
2. Go to Workspace > Accounting.
3. Click on Export > Preferred exporter
4. Click on value.

Expected Result:

When the value chosen in the third step is selected, the app redirects to the Export page.

Actual Result:

The app does not redirects to the Export page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6741580_1739430260092.Screen_Recording_2025-02-13_at_9.11.29_in_the_morning.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

⚠️ @parasharrajat Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[parasharrajat]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After selecting a Preferred exporter , user is not taken back to the Export Settings page.

What is the root cause of that problem?

There are two issues that I noticed.

1. Selecting the exporter throws an error in the code as we are trying to access a property that does not exist.

2. We are using the wrong route on the same page. It should be an export page.

https://github.com/Expensify/App/blob/main/src/pages/workspace/accounting/qbo/export/QuickbooksPreferredExporterConfigurationPage.tsx#L59

What changes do you think we should make in order to solve the problem?

1. We should add a check for null value on exporter prop.
   

   App/src/pages/workspace/accounting/qbo/export/QuickbooksPreferredExporterConfigurationPage.tsx

   Line 57 in 4f3a2ee

   QuickbooksOnline.updateQuickbooksOnlinePreferredExporter(policyID, {exporter: row.value}, {exporter: qboConfig?.export.exporter ?? ''});

QuickbooksOnline.updateQuickbooksOnlinePreferredExporter(policyID, {exporter: row.value}, {exporter: qboConfig?.export?.exporter ?? ''});

2. We should change the route to Export page.

ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_ONLINE_EXPORT.getRoute(policyID)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None, I belive its a mistake. But happy to work on suggestions.

What alternative solutions did you explore? (Optional)

None.

[parasharrajat]

I can fix this asap.

[parasharrajat]

This issue is not caused by #49539. Looks like it was already present. Probably not a deploy blocker. cc: @mountiny

[SzymczakJ]

Whoops linked my PR to this issue by mistake

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix Preferred export page settings routing #56822

If no regressions arise, payment will be issued on 2025-02-25. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot]

@parasharrajat / @shubham1206agra @twisterdotcom @parasharrajat / @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[shubham1206agra]

@mountiny, I do not require payment for this issue, as it will be handled by the parent issue. And since the fix was simple, I would recommend $50 to the author of the PR.

[twisterdotcom]

Okay so, payment summary:

• @parasharrajat paid $250 via NewDot Requests

[parasharrajat]

@twisterdotcom I disagree with the payment above. Payment cut should happen for the original author and C+ of the PR which caused this regression. It was a deploy blocker and I put up a fix in a timely manner and I was not the author of the original PR.

This should be a standard payment for me. There are many examples that I can bring up. This is another regression issue caused by the same PR #56797 (comment) with a standard payout to the contributor. This could also be considered a simple fix.

I also invested time looking into a few more flows to find the same issue.

[mountiny]

Yeah this should be a standard payment as @parasharrajat was not author of the PR that caused this bug (that was very large though so hard to blame), reopening to fix this

[twisterdotcom]

Updated payment summary.