Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Copilot - Copilot can access member's chat history which leads to not here page #56825

Closed
2 of 8 tasks
IuliiaHerets opened this issue Feb 13, 2025 · 9 comments
Closed
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other

Action Performed:

Precondition:

  • User has access to another member's account.
  • User has at least one workspace.
  1. Launch ND or hybrid app.
  2. Go to workspace chat.
  3. Tap on the report header.
  4. Tap Go to workspace.
  5. Tap on profile icon on the bottom bar.
  6. Open account switcher.
  7. Select another account.
  8. Tap device back button.
  9. Tap device back button again.

Expected Result:

The copilot will not be able to access the other member's chat history via device back button.

Actual Result:

The copilot is able to access the other member's chat history via device back button, which leads to not here page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6741602_1739432740094.Screen_Recording_20250213_153643_Expensify.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 13, 2025

💬 A slack conversation has been started in #expensify-open-source

@IuliiaHerets
Copy link
Author

Prod has another behavior

screen-20250213-101432.mp4

@mountiny
Copy link
Contributor

This will most likely be related to the navigation changes https://expensify.slack.com/archives/C01GTK53T8Q/p1739435484596829?thread_ts=1739328522.587109&cid=C01GTK53T8Q but I am not sure if I understand the core issue here. You can also change to the copilot in production but you need to go to the settings page from outside of the workspace detail page, what happens then when you go back?

@parasharrajat
Copy link
Member

parasharrajat commented Feb 13, 2025

I believe it is expected behavior. We are not able to access the chat history. Browser still has old navigation history after you switch to copilot and when you go back to those old reports, it will show not here as those chats belonged to the old account which looks good to me. This is the same as accessing a random chat via URL.

I don't think we can clear the whole navigation stack of the user.

@WojtekBoman
Copy link
Contributor

I agree with @parasharrajat, it's a new flow where visited chat screens remain in the navigation history and we can go back to them after switching the account, I am not sure if we should clear nav history after switching the account, because I assume that if we had access to the previous account chats we would like to be able to go back to them, so it's a more complex case.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 14, 2025
@mountiny
Copy link
Contributor

Cool, I agree with the reasoning here, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants