Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expense - Clicking on tooltip is not functional #57365

Open
4 of 8 tasks
mitarachim opened this issue Feb 25, 2025 · 9 comments
Open
4 of 8 tasks

Expense - Clicking on tooltip is not functional #57365

mitarachim opened this issue Feb 25, 2025 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.5-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #56759
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Money Requests

Action Performed:

  1. Navigate to https://staging.new.expensify.com
  2. Login with applause.expensifail.com domain account
  3. Open FAB > Select Create Expense
  4. Select Manual > Add some amount
  5. Go to select participant page
  6. Search for manager
  7. Notice that Manager McTest is visible and tooltip for selecting it for testing is visible
  8. Click in the Tooltip shown.

Expected Result:

Clicking on the tooltip selects the Manager McTest

Actual Result:

Clicking on tooltip is not functional.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6753204_1740448523659.Screen_Recording_2025-02-25_at_4.31.51_at_night.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Feb 25, 2025
Copy link

melvin-bot bot commented Feb 25, 2025

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 25, 2025

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 25, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 25, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@daledah
Copy link
Contributor

daledah commented Feb 25, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on tooltip is not functional.

What is the root cause of that problem?

In PR, we are missing onTooltipPress in when using tooltip:

What changes do you think we should make in order to solve the problem?

We should handle the press tooltip event:

                    onTooltipPress={() => {
                        onSelectRow(item);
                        hideProductTrainingTooltip();
                    }}

The bug appears in this button as well:


so we need to address it by the similar way, that is adding onTooltipPress function.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

@robertjchen robertjchen added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Feb 25, 2025
@parasharrajat
Copy link
Member

cc: @DylanDylann

@DylanDylann
Copy link
Contributor

It is intentional, we are going to complete this soon

cc @kubabutkiewicz

Copy link

melvin-bot bot commented Feb 28, 2025

@robertjchen, @abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

@abekkala
Copy link
Contributor

PR was deployed, but reverted

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants