Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2021-11-04] Scrolling Payments page on iOS hides available options #5744

Closed
kavimuru opened this issue Oct 10, 2021 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Oct 10, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open app and login
  2. Login with an account.
  3. Go to Profile Icon > Payments

Expected Result:

Payments Page should not scroll or should be able to scroll without any weird behavior or text hidden

Actual Result:

When scrolling down "Add payment method" hides

Workaround:

N/A

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.1.7

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5270616_Ios_pay.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

Proposal

To fix this:

Add a ScrollView to the whole page with flex:1 and disable the bouncing effect on the PaymentMethodList's Flatlist.

@nkuoch nkuoch added the External Added to denote the issue can be worked on by a contributor label Oct 11, 2021
@MelvinBot
Copy link

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@parasharrajat
Copy link
Member

@stephanieelliott was assigned accidentally.

@MelvinBot MelvinBot added Overdue and removed Overdue labels Oct 14, 2021
@stephanieelliott stephanieelliott added Weekly KSv2 Daily KSv2 and removed Daily KSv2 Weekly KSv2 labels Oct 14, 2021
@stephanieelliott stephanieelliott changed the title iOS - Settings - Able to scroll the payment page and scrolling is weird Scrolling Payments page on iOS hides available options Oct 14, 2021
@stephanieelliott
Copy link
Contributor

Posted to Upwork: https://www.upwork.com/jobs/~0107941cc4671e58a1

@MelvinBot MelvinBot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Daily KSv2 labels Oct 14, 2021
@MelvinBot
Copy link

Triggered auto assignment to @thienlnam (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@thienlnam
Copy link
Contributor

🟢 on @parasharrajat's proposal

@stephanieelliott Could you please hire @parasharrajat in upwork and assign him to this issue?

@parasharrajat parasharrajat mentioned this issue Oct 15, 2021
5 tasks
@stephanieelliott
Copy link
Contributor

Sent you the offer, @parasharrajat!

@MelvinBot MelvinBot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 15, 2021
@stephanieelliott
Copy link
Contributor

stephanieelliott commented Oct 22, 2021

N6 hold is lifted! PR is not yet merged to prod, undergoing QA.

@stephanieelliott
Copy link
Contributor

This was deployed to prod yesterday, starting 7-day regression period. Note to include $250 bonus with job payment.

@stephanieelliott stephanieelliott changed the title Scrolling Payments page on iOS hides available options [Hold for payment 11/4] Scrolling Payments page on iOS hides available options Oct 29, 2021
@mountiny mountiny added the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 30, 2021
@mountiny mountiny changed the title [Hold for payment 11/4] Scrolling Payments page on iOS hides available options [HOLD for payment 2021-11-04] Scrolling Payments page on iOS hides available options Oct 30, 2021
@stephanieelliott
Copy link
Contributor

Paid in Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants