Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow phone numbers that are less than 5 digits long #5936

Closed
Luke9389 opened this issue Oct 18, 2021 · 2 comments
Closed

Don't allow phone numbers that are less than 5 digits long #5936

Luke9389 opened this issue Oct 18, 2021 · 2 comments
Assignees
Labels
Improvement Item broken or needs improvement. Weekly KSv2

Comments

@Luke9389
Copy link
Contributor

Luke9389 commented Oct 18, 2021

Conversation here: #5531 (comment)

Action Performed:

In the VBA flow, input a phone number that's 3 digits long.

Expected Result:

We should validate this field in a way that disallows 3 digit phone numbers.

Actual Result:

No error will show (we're only enforcing a digit maximum right now).

Workaround:

N/A

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@Luke9389 Luke9389 added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Oct 18, 2021
@Luke9389 Luke9389 self-assigned this Oct 18, 2021
@MelvinBot
Copy link

Triggered auto assignment to @michaelhaxhiu (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2021
@Luke9389 Luke9389 added Weekly KSv2 and removed Daily KSv2 labels Oct 18, 2021
@Luke9389
Copy link
Contributor Author

Hey sorry for the spam @michaelhaxhiu, I'm just gonna do this one so no need for triage.

@Luke9389 Luke9389 added the Improvement Item broken or needs improvement. label Oct 18, 2021
@botify botify closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants