Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on import * as Something when modules only have named exports #6072

Closed
Tracked by #5984
marcaaron opened this issue Oct 27, 2021 · 1 comment
Closed
Tracked by #5984

Standardize on import * as Something when modules only have named exports #6072

marcaaron opened this issue Oct 27, 2021 · 1 comment
Assignees
@marcaaron
Labels
Monthly KSv2 Reviewing Has a PR in review

Comments

@marcaaron
Copy link
Contributor

No description provided.

@marcaaron marcaaron mentioned this issue Oct 27, 2021
Closed
14 tasks
@marcaaron marcaaron changed the title Standardize on import * as SomethingActions for "action" files Standardize on import * as Something when modules only have named exports Oct 27, 2021
@MelvinBot MelvinBot added the Monthly KSv2 label Nov 1, 2021
@marcaaron
Copy link
Contributor Author

Heads up the rule for this was added in eslint-config-expensify so to tackle this one we need to:

  1. Turn the rule on by adding rulesdir/prefer-import-module-contents to this file
  2. Create a new PR in Expensify/App that bumps the eslint config version and fixes all these usages

@marcaaron marcaaron self-assigned this Nov 12, 2021
@marcaaron marcaaron mentioned this issue Nov 12, 2021
Merged
5 tasks
@marcaaron marcaaron added the Reviewing Has a PR in review label Nov 22, 2021
@marcaaron marcaaron mentioned this issue Nov 22, 2021
Merged
@botify botify closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcaaron marcaaron

Labels
Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@botify @MelvinBot @marcaaron