Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the step counter from "Let's finish in chat" step of VBA flow #6123

Closed
kevinksullivan opened this issue Oct 29, 2021 · 4 comments
Closed
Assignees
Labels

Comments

@kevinksullivan
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Problem

The step counter within the VBA flow should not show in the "Let's finish in chat" step, which causes there to be two pages shown as "Step 5 of 5". Additionally, the copy on this page is fairly vague in explaining what we need from the user:

Thanks for doing that! We have a couple more things to work out, but it'll be easier over chat. Ready to chat?

image

Action Performed:

  1. Create a workspace
  2. Go to Connect bank account page within the workspace editor
  3. Tap Connect manually and go through VBA steps using (1) within these instructions
  4. Arrive at step that has the "Let's finish in chat" header

Solution

  1. Remove the step counter from this step so that we don't show "step 5 of 5" prematurely.
  2. Update the copy within the step to:

Thanks for doing that! We need your help verifying a few pieces of information, but we can work this out quickly over chat. Ready?

View all open jobs on GitHub

@kevinksullivan kevinksullivan added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Oct 29, 2021
@MelvinBot
Copy link

Triggered auto assignment to @SofiedeVreese (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 29, 2021
@SofiedeVreese
Copy link
Contributor

SofiedeVreese commented Nov 1, 2021

Looks good, let's do it!

Adding Engineering for further triaging.

@MelvinBot
Copy link

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@SofiedeVreese SofiedeVreese removed their assignment Nov 1, 2021
@thienlnam
Copy link
Contributor

Marking this as internal since only we can test the VBA flows. Can't pick it up right now so dropping it back in the pool

For the engineering handling this - current step is the ValidationStep

And the step counter is located in the component HeaderWithCloseButton. Seems like the simplest solution would to just pass down a prop like shouldShowStepCounter and hide the

<Header
title={props.title}
subtitle={props.stepCounter ? props.translate('stepCounter', props.stepCounter) : ''}
/>

@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels Nov 1, 2021
@thienlnam thienlnam removed their assignment Nov 1, 2021
@luacmartins luacmartins self-assigned this Nov 2, 2021
@luacmartins luacmartins added the Reviewing Has a PR in review label Nov 2, 2021
@botify botify closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants