Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHN - Changing priority to #focus mode doesn't reflect the changes in LHN #6231

Closed
kavimuru opened this issue Nov 5, 2021 · 6 comments
Closed
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Nov 5, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open app and login
  2. Tap on profile icon
  3. Go to preferences > priority mode > change to #focus
  4. Go back to LHN

Expected Result:

User is able to activate #focus mode - only conversations with unread, draft or pinned messages are seen

Actual Result:

Setting #focus mode won't change anything in LHN

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.14-0

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5313039_20211104_224558.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Nov 5, 2021
@kavimuru kavimuru changed the title LHN - Changing priority mode to #focus mode doesn't reflect the changes in LHN LHN - Changing priority to #focus mode doesn't reflect the changes in LHN Nov 5, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Nov 5, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

Could this please be retested on #6084? I believe there is a chance it is already solved there.

@iwiznia
Copy link
Contributor

iwiznia commented Nov 5, 2021

@kavimuru can you retest? The fix is already deployed to staging #6240 (comment)

@isagoico
Copy link

isagoico commented Nov 5, 2021

I'm still able to reproduce this issue in 1.1.14-1
image

@chiragsalian chiragsalian assigned chiragsalian and unassigned iwiznia Nov 5, 2021
@chiragsalian chiragsalian added the Reviewing Has a PR in review label Nov 5, 2021
@botify botify closed this as completed Nov 5, 2021
@chiragsalian
Copy link
Contributor

chiragsalian commented Nov 5, 2021

This should be fixed in 1.1.14-2. Feel free to retest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

8 participants