[HOLD for payment 2022-03-08] [$500] Account details stuck in RHN when switching chats

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click header in conversation with User B - their details open in Right Hand Nav (RHN)
2. Type command+k to open Search to open chat with User C
3. Observe account details for User B still shows in RHN while new chat is open in the background for User C

Expected Result:

Once new chat with User C is open, RHN is completely removed/disappears

Actual Result:

Account details stuck in RHN

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Desktop App

Version Number: 1.1.18-3
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
**Slack conversation:https://expensify.slack.com/archives/C01GTK53T8Q/p1639175807048600

Job Post: https://www.upwork.com/jobs/~01a4bf9b60eba80639

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @kevinksullivan (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MelvinBot]

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sketchydroide]

this does sound like a bug, and I think we could have it as an external

[MelvinBot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @chiragsalian (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Santhosh-Sellavel]

Proposal

We need to invoke dismissModal from here. So whenever we navigate to a new report, RHN modals would disappear.

App/src/libs/Navigation/Navigation.js

Lines 143 to 146 in 9f2b4f0

	if (isDrawerRoute(route)) {
	navigationRef.current.dispatch(CustomActions.pushDrawerRoute(route));
	return;
	}

Like this,

if (isDrawerRoute(route)) {
     dismissModal();
     navigationRef.current.dispatch(CustomActions.pushDrawerRoute(route));
     return;
}

Also, we will need to refactor dismissModal, i.e need to move the function above the navigate method because we cannot use the method before defining it.

[aswin-s]

Reason

Open modals are not dismissed before opening overlapping drawers. Similar behaviour is observed while trying to create new groups by pressing Ctrl+Shift+K.

Proposal

Dismiss any open modals before navigating to a modal screen through keyboard shortcut listener.

Keyboard listeners for search & new groups are getting registered over here :-

https://github.com/Expensify/App/blob/main/src/libs/Navigation/AppNavigator/AuthScreens.js#L164-L169

My proposal is to invoke Navigation.dismissModal() before navigating to new modal, so that it will close any open modals before opening the search drawer when invoked via keyboard shortcut.

        // Listen for the key K being pressed so that focus can be given to
        // the chat switcher, or new group chat
        // based on the key modifiers pressed and the operating system
        this.unsubscribeSearchShortcut = KeyboardShortcut.subscribe(searchShortcutConfig.shortcutKey, () => {
            Navigation.dismissModal();
            Navigation.navigate(ROUTES.SEARCH);
        }, searchShortcutConfig.descriptionKey, searchShortcutModifiers, true);
        this.unsubscribeGroupShortcut = KeyboardShortcut.subscribe(groupShortcutConfig.shortcutKey, () => {
            Navigation.dismissModal();
            Navigation.navigate(ROUTES.NEW_GROUP);
        }, groupShortcutConfig.descriptionKey, groupShortcutModifiers, true);

Result

fix.mp4

[parasharrajat]

Reviewing proposals...

[parasharrajat]

Both of the proposals work but they are not full-proof solutions. I would be glad if someone can really pick the right cause and propose a fix for that.

Open modals are not dismissed before opening overlapping drawers. Similar behaviour is observed while trying to create new groups by pressing Ctrl+Shift+K.

This is not a reason. It more sounds like the issue statement.

To add more to the context.

1. A solution must be fixing the CustomActions.pushDrawerState.
2. This happens when two or more of the modal Screens are active on the RootStack.Navigator.
3. When point 2 happens, it creates three routes on the navigation state. Home (Report Screen) => Details => Search. Currently CustomActions.pushDrawerState is able to close the Search and take you back to Home but Details Route is not cleared.
4. Navigation.dismissModal() should only be triggered when point 2 type of navigation (e.g Home => Details => Search.) happens but not when Home => Details.

[parasharrajat]

Waiting for proposals...

[chiragsalian]

Still waiting on proposals

[hiteshagja]

Thanks @chiragsalian. I will raise PR in the morning IST.

[hiteshagja]

@parasharrajat Need new upwork Job posting b/c the old one expired.

[parasharrajat]

cc: @kevinksullivan

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.40-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix:: Account details stuck in RHN when switching chats #7725

If no regressions arise, payment will be issued on 2022-03-08. 🎊

[hiteshagja]

@kevinksullivan @parasharrajat

Could you please send upwork job external link or an offer?

[parasharrajat]

@hiteshagja That can be arranged on the payment date. Be assured for the payment.

But before that, we faced a regression which I think is caused by your PR. https://expensify.slack.com/archives/C01GTK53T8Q/p1646351449854569

[hiteshagja]

I will look into.

[kevinksullivan]

Apologies @hiteshagja , I was OOO. Invited you to apply for the new job

https://www.upwork.com/jobs/~01a4bf9b60eba80639

[parasharrajat]

Please reopen this issue @kevinksullivan

[hiteshagja]

@parasharrajat

I have tried a lot to re-generate this issue but I could not. It's working fine for me. If it's still happening in yours then could you please suggest steps to re-generate the same.

expensifyDesktopApp_1.mp4

[parasharrajat]

It happens sometimes only.

1. Open the app directly via URL localhost.8080.
2. Open the newChat page from heavy_plus_sign: and then click on any chat to open.
3. Sometimes, opening the new Chat does not land on the requested chat instead the last recent open chat is refreshed.
4. Try mixing the navigation via LHN or the New Chat page.

[hiteshagja]

@parasharrajat

I have tried steps provided and tried many random steps (LHN + New Chat) + RHN but never come across scenario which you described. It's all working fine. Even tried different logins to check the same but that also worked well.

[kevinksullivan]

Noting there are potential regressions being investigated, so holding off on payment for now.

[parasharrajat]

I think we are good for payment. Nobody is facing that issue again.

[kevinksullivan]

Offer sent @hiteshagja and @parasharrajat . Once you accept I'll get this payment taken care of!

[hiteshagja]

Accepted @kevinksullivan

[kevinksullivan]

Paid @hiteshagja . @parasharrajat just sent offer so can pay once you accept. Thanks!

[parasharrajat]

@kevinksullivan Done.

[kevinksullivan]

All set.