Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android build failing after RN upgrade #7111

Closed
Jag96 opened this issue Jan 10, 2022 · 3 comments
Closed

Android build failing after RN upgrade #7111

Jag96 opened this issue Jan 10, 2022 · 3 comments
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@Jag96
Copy link
Contributor

Jag96 commented Jan 10, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

Run the deploy

Expected Result:

Android builds successfully

Actual Result:

Fastlane failed with the following error:

Execution failed for task ':app:mergeReleaseAssets'.
> Could not resolve all files for configuration ':app:releaseRuntimeClasspath'.
   > Could not find com.facebook.flipper:flipper-noop:0.66.0.

Original thread here: https://expensify.slack.com/archives/C03V9A4TB/p1641843892079000

Workaround:

None

Platform:

Where is this issue occurring?

  • Android
@Jag96 Jag96 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Jan 10, 2022
@Jag96 Jag96 self-assigned this Jan 10, 2022
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 10, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Current assignee @Jag96 is eligible for the Engineering assigner, not assigning anyone new.

@Jag96 Jag96 added Daily KSv2 and removed Hourly KSv2 labels Jan 10, 2022
@Jag96
Copy link
Contributor Author

Jag96 commented Jan 10, 2022

Looks like setting the noop version for Flipper for release builds will fix the issue:

releaseImplementation "com.facebook.flipper:flipper-noop:${FLIPPER_VERSION}"

Still looking into what actually caused this error just to confirm there aren't any other steps required for this fix.

The error specifies

[18:53:09]: ▸ Required by:
[18:53:09]: ▸ project :app > project :flipper-plugin-react-native-performance

But that package didn't change in our project during the upgrade: https://github.com/Expensify/App/pull/6914/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L97

We also have a separate package included for flipper-plugin-react-native-performance, but looking at the npm page for that it seems to be deprecated.

That package was introduced in #4760, so going to see if removing it fixes the issue and passes the tests on that PR.

@Jag96 Jag96 added the Reviewing Has a PR in review label Jan 10, 2022
@botify botify closed this as completed Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants