Send Money - "Delete comment" appears instead of sent $ money in LHN after refresh the page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. Open a chat with any user
4. Click the "+" button and then "Send money"
   
5. Enter any amount, then click "Next"
6. Use the option "I'll settle up elsewhere" on drop down menu.
7. Refresh the page

Expected Result:

Message displayed in LHN - "Sent $amount elsewhere

Actual Result:

"[Delete comment]" appears instead of sent $ money in LHN after refresh the page

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.39-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.226.mp4

Bug5455431_Screen_Recording_20220215-215650_New_Expensify.mp4

Bug5455431_Image_from_iOS__15_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

Issue was found when executing: #7552

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[aldo-expensify]

The report prop had the following value in my case:

{.  // report
    "hasIOUAction": true,
    "isPinned": false,
    "reportActionCount": 2,
    "lastActionActorEmail": "[email protected]",
    "lastActionCreated": "2022-02-16 23:58:32",
    "lastActionMessage": {
        "IOUDetails": {
            "amount": 12300,
            "comment": "",
            "currency": "CAD"
        },
        "IOUReportID": 9090,
        "paymentType": "Elsewhere",
        "type": "pay"
    },
    "lastActionType": "IOU",
    ...
}

Since there is no report.lastActionMessage.html, the variable lastActionMessage gets initialized to '' here, then here, lastMessageText gets assigned [${Localize.translateLocal('common.deletedCommentMessage')}]

[aldo-expensify]

Updated instructions with simpler steps

[aldo-expensify]

Oh, it broke because of change in Web-E

[MelvinBot]

Triggered auto assignment to @jliexpensify (Internal) because issue was reported by a contributor who needs to be compensated if this issue is fixed

[aldo-expensify]

was it reported by a contributor?

[mvtglobally]

@aldo-expensify NOT reported by a Contributor. Our team noticed it and @joekaufmanexpensify raised it as well in Slack

[jliexpensify]

@aldo-expensify - no need to create a job in Upworks right? Is this being handled internally?

[aldo-expensify]

@jliexpensify nop, no need to create job in Upworks.

[jliexpensify]

Cheers Aldo, going to unassign myself!

[aldo-expensify]

No overdue, PR merged, but not deployed yet

[aldo-expensify]

No overdue, PR will be tested in Production

[aldo-expensify]

This was fixed in this PR, but a similar issue remains...

The last message [Comment deleted] only goes away after refresh, which is somewhat inconsistent.

Screen.Recording.2022-03-03.at.10.25.12.PM.mov

I think this has to be fixed in the front end, so I created new GH issue for it: #8001