Workspace - Second line in the error message for invalid phone number invite is incorrect

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com

2. Create a new workspace from an account that's on the policyExpenseChat beta (e.g @expensifail.com)

3. Add a new invalid member to the workspace via Manage Members > Invite

Expected Result:

Correct error message should appear

Actual Result:

Incorrect error message in the 2nd line without any spacing too

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.54.0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Puneet-here]

Proposal

Reason: This is happening because workspace.invite.pleaseEnterValidLogin doesn't exist there is no such key in en.js or es.js

App/src/libs/actions/Policy.js

Line 352 in 43910fe

policyDataWithoutLogin.alertMessage += ` ${Localize.translateLocal('workspace.invite.pleaseEnterValidLogin')}`;

Fix: we have multiple ways to solve this,

1. We can remove lines from 351 to 353 because we are already showing an error message so if we remove these lines then only this error message will be shown: "An error occurred inviting the user to the workspace, please try again."

2. We can add a key in en.js and es.js so the user will see the generic error message and the error message we will be adding.
   

   App/src/libs/actions/Policy.js

   Lines 350 to 353 in 43910fe

   	policyDataWithoutLogin.alertMessage = Localize.translateLocal('workspace.invite.genericFailureMessage');
   	if (data.jsonCode === 402) {
   	policyDataWithoutLogin.alertMessage += ` ${Localize.translateLocal('workspace.invite.pleaseEnterValidLogin')}`;
   	}

3. We can add the key but instead of adding the error message with the generic message we can just show the new error message, like this:

 if (data.jsonCode === 402) {
     policyDataWithoutLogin.alertMessage = Localize.translateLocal('workspace.invite.pleaseEnterValidLogin');
}

[Julesssss]

Thanks for the proposals, but I'm going to close this as this issue a a duplicate of this issue

[luacmartins]

@kavimuru could you please update the original reporter of this issue, since it seems to be reported by @thesahindia and not applause as per this Slack thread? Let me know once it's updated and we will move forward with paying the contributor.

[luacmartins]

Adding External label to pay the reporting bonus. This issue was solved internally, so we can close it once the bonus is paid out.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[luacmartins]

@MitchExpensify could you please pay the reporting bonus to @thesahindia and close this issue once done? Thank you!

[MitchExpensify]

Cannn do! Upwork Job created and I've invited @thesahindia for reporting bonus payment

[thesahindia]

Applied ✅

[MitchExpensify]

Offer sent!

[thesahindia]

Accepted the offer.
Thanks.

[MitchExpensify]

Paid and contract ended! closing