[HOLD for payment 2022-08-30] [$250] Android - Deep Links not working on Android 12+@tomivs

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Log in to NewDot on the app.
2. From an email or external source, click on the link https://new.expensify.com/statements/202202/
3. Verify that the link is opened in the native app, and not the web browser.

Expected Result:

Links should open in Expensify App in Android 12

Actual Result:

Links not working on Android 12+

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Android

Version Number: 1.1.79.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.10.1.MP4

Expensify/Expensify Issue URL:

Issue reported by: @tomivs

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1650935563541709

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcochavezf]

The deep links are working fine for me on Android 11, but according to the slack convo and doing a quick search on Google seems the deep links (App Links on Android) are indeed broken for Android 12.

Seems the solution can be implemented by an external contributor.

[melvin-bot]

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[rushatgabhane]

@tomivs I remember you having a proposal for this issue, please submit one if you're interested :)

[arielgreen]

https://www.upwork.com/jobs/~018ff7d1127f315de9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[melvin-bot]

Triggered auto assignment to @deetergp (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[as-if-iam]

Maybe this will help you : https://doordash.engineering/2022/01/25/your-deep-links-might-be-broken-web-intents-and-android-12/

[tomivs]

Thanks guys. I'll post a proposal soon...

[mim1192]

XML FOLDER PERMISSION REQUIRED ONLY TO RESOLVE IT

[parasharrajat]

@asif84468 @tomivs @mim1192 Please submit your proposals if you are interested to solve this issue.

[tomivs]

As I mentioned in this comment: #8656 (comment)

Root cause:

Changes for App Links on Android 12

Proposal:

Update App Links for Android 12 which would include:

• Upgrading target SDK version:
  • Update targetSdkVersion to 31 (Android 12) in build.gradle.
  • Update some old npm packages to versions that support Android 12.
• Update AndroidManifest.xml following Android 12 guidelines.

[tomivs]

@arielgreen Just applied!

[arielgreen]

Hired!

[tomivs]

Just opened the PR. Waiting for your reviews and testing.

[deetergp]

Not overdue. PR is in review.

[arielgreen]

Still in review

[deetergp]

This PR was merged 4 days ago. We've got another 3 days to go for regressions then we'll pay it out.

[tomivs]

Are the 7 days for regression over? Just a friendly bump since last time the bot didn't say anything after the 7 days.

[parasharrajat]

Not yet. We are facing deployment issues PR is still in staging.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.88-15 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Deep Links not working on Android 12+ #10128

If no regressions arise, payment will be issued on 2022-08-30. 🎊

[tomivs]

Were there any regressions?

[parasharrajat]

it will be paid today if there are no regressions.

[tomivs]

Any news on this?

cc: @arielgreen @deetergp

[arielgreen]

@tomivs payment sent.

@parasharrajat check your Upwork inbox please :)

[deetergp]

@tomivs Have you received payment in your account yet?

[arielgreen]

All contributors have been paid, closing.