Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Pressing Enter key is selected different currency, and up and down keys don't work #9678

Closed
kbecciv opened this issue Jul 1, 2022 · 2 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Jul 1, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue was found when executing PR #7702

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Click the FAB button and select Request Money
  3. Click on the currency
  4. In the search function, enter "US"

Expected Result:

Focus works correctly and keys up and down work correctly if there are only 2 currencies in the list

Actual Result:

  1. When you type "US" the focus goes to another incorrect currency and incorrect currency selected when pressing Enter key.
  2. Keys up and down do not work when there are only 2 currencies.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.79.9

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): [email protected]/Yulia1986Gerets

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5633022_Recording__974.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 1, 2022

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@roryabraham
Copy link
Contributor

Got a PR up to fix this: #9682

@roryabraham roryabraham added the Reviewing Has a PR in review label Jul 1, 2022
@melvin-bot melvin-bot bot closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants