Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken defaultProps in IOUAmountPage #9889

Closed
luacmartins opened this issue Jul 13, 2022 · 0 comments
Closed

Fix broken defaultProps in IOUAmountPage #9889

luacmartins opened this issue Jul 13, 2022 · 0 comments
Assignees

Comments

@luacmartins
Copy link
Contributor

Problem

Coming from this comment, the defaultProps in IOUAmountPage doesn't work, because if any keys in props.iou is defined, we don't check that iou.selectedCurrencyCode is actually set.

Why is this important?

It makes the code cleaner and less confusing

Solution

Remove the broken default props

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant